Disable pausing background videos on desktop in 58. |
||||||||||
Issue descriptionWe found that resuming video only players on desktop takes too much time when paused, so we need to disable that until we solve the performance problem.
,
Mar 7 2017
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a44cbf733c9d8f7589bd2856c0247486f3a7cce commit 0a44cbf733c9d8f7589bd2856c0247486f3a7cce Author: avayvod <avayvod@chromium.org> Date: Tue Mar 07 20:40:52 2017 Revert of Disable pausing background video-only players on desktop. (patchset #2 id:20001 of https://codereview.chromium.org/2734963003/ ) Reason for revert: Was intended only to merge to 58. Original issue's description: > Disable pausing background video-only players on desktop. > > The intent is to merge this to M58 to launch the background video > optimizations that do both pausing for video-only and disabling the > video track for audible videos. > > BUG= 699106 > TEST=existing tests > > Review-Url: https://codereview.chromium.org/2734963003 > Cr-Commit-Position: refs/heads/master@{#455187} > Committed: https://chromium.googlesource.com/chromium/src/+/60588ea13e075f43e47cd97d6911b8c50ce5d579 TBR=dalecurtis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 699106 Review-Url: https://codereview.chromium.org/2738793002 Cr-Commit-Position: refs/heads/master@{#455203} [modify] https://crrev.com/0a44cbf733c9d8f7589bd2856c0247486f3a7cce/content/browser/media/session/media_session_impl_visibility_browsertest.cc [modify] https://crrev.com/0a44cbf733c9d8f7589bd2856c0247486f3a7cce/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/0a44cbf733c9d8f7589bd2856c0247486f3a7cce/media/blink/webmediaplayer_impl_unittest.cc
,
Mar 7 2017
To clarify, requesting the merge of #c1 to 58.
,
Mar 8 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 8 2017
Alex, FYI the original CL was created to disable a part of an experimental feature in 58 before trying to launch the experiment 100%. Thus it was reverted on trunk.
,
Mar 9 2017
-amineer +govind It's actually a non-Android change :)
,
Mar 9 2017
Before we approve merge to M58, could you please confirm CL listed at #1 is well baked/verified in Canary, having enough automation test coverage (I do see browsers and unit tests in cl) and safe to merge to M58?
,
Mar 9 2017
According to omaha both the change and the revert made it into the same canary release 59.0.3034.0 so I don't think it will be possible to verify it on Canary as is :( I can confirm the change in a local build and that it has enough coverage. It disables part of an experiment on desktop so should be pretty harmless IMO.
,
Mar 9 2017
Thank you avayvod@. Approving merge to M58 branch 3029 based on comment #9. Please merge ASAP. Thank you.
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c784820b54f8eeda51d9f02de7d2b9792894f34b commit c784820b54f8eeda51d9f02de7d2b9792894f34b Author: Anton Vayvod <avayvod@google.com> Date: Thu Mar 09 21:47:11 2017 Disable pausing background video-only players on desktop. The intent is to merge this to M58 to launch the background video optimizations that do both pausing for video-only and disabling the video track for audible videos. BUG= 699106 TEST=existing tests Review-Url: https://codereview.chromium.org/2734963003 Cr-Commit-Position: refs/heads/master@{#455187} (cherry picked from commit 60588ea13e075f43e47cd97d6911b8c50ce5d579) Review-Url: https://codereview.chromium.org/2741083002 . Cr-Commit-Position: refs/branch-heads/3029@{#93} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/c784820b54f8eeda51d9f02de7d2b9792894f34b/content/browser/media/session/media_session_impl_visibility_browsertest.cc [modify] https://crrev.com/c784820b54f8eeda51d9f02de7d2b9792894f34b/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/c784820b54f8eeda51d9f02de7d2b9792894f34b/media/blink/webmediaplayer_impl_unittest.cc
,
Mar 9 2017
,
Nov 7 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 7 2017