New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699106 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Disable pausing background videos on desktop in 58.

Project Member Reported by avayvod@chromium.org, Mar 7 2017

Issue description

We found that resuming video only players on desktop takes too much time when paused, so we need to disable that until we solve the performance problem.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60588ea13e075f43e47cd97d6911b8c50ce5d579

commit 60588ea13e075f43e47cd97d6911b8c50ce5d579
Author: avayvod <avayvod@chromium.org>
Date: Tue Mar 07 20:08:19 2017

Disable pausing background video-only players on desktop.

The intent is to merge this to M58 to launch the background video
optimizations that do both pausing for video-only and disabling the
video track for audible videos.

BUG= 699106 
TEST=existing tests

Review-Url: https://codereview.chromium.org/2734963003
Cr-Commit-Position: refs/heads/master@{#455187}

[modify] https://crrev.com/60588ea13e075f43e47cd97d6911b8c50ce5d579/content/browser/media/session/media_session_impl_visibility_browsertest.cc
[modify] https://crrev.com/60588ea13e075f43e47cd97d6911b8c50ce5d579/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/60588ea13e075f43e47cd97d6911b8c50ce5d579/media/blink/webmediaplayer_impl_unittest.cc

Labels: Merge-Request-58
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a44cbf733c9d8f7589bd2856c0247486f3a7cce

commit 0a44cbf733c9d8f7589bd2856c0247486f3a7cce
Author: avayvod <avayvod@chromium.org>
Date: Tue Mar 07 20:40:52 2017

Revert of Disable pausing background video-only players on desktop. (patchset #2 id:20001 of https://codereview.chromium.org/2734963003/ )

Reason for revert:
Was intended only to merge to 58.

Original issue's description:
> Disable pausing background video-only players on desktop.
>
> The intent is to merge this to M58 to launch the background video
> optimizations that do both pausing for video-only and disabling the
> video track for audible videos.
>
> BUG= 699106 
> TEST=existing tests
>
> Review-Url: https://codereview.chromium.org/2734963003
> Cr-Commit-Position: refs/heads/master@{#455187}
> Committed: https://chromium.googlesource.com/chromium/src/+/60588ea13e075f43e47cd97d6911b8c50ce5d579

TBR=dalecurtis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 699106 

Review-Url: https://codereview.chromium.org/2738793002
Cr-Commit-Position: refs/heads/master@{#455203}

[modify] https://crrev.com/0a44cbf733c9d8f7589bd2856c0247486f3a7cce/content/browser/media/session/media_session_impl_visibility_browsertest.cc
[modify] https://crrev.com/0a44cbf733c9d8f7589bd2856c0247486f3a7cce/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/0a44cbf733c9d8f7589bd2856c0247486f3a7cce/media/blink/webmediaplayer_impl_unittest.cc

To clarify, requesting the merge of #c1 to 58.
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 8 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: amineer@chromium.org
Alex, FYI the original CL was created to disable a part of an experimental feature in 58 before trying to launch the experiment 100%. Thus it was reverted on trunk.
Cc: -amineer@chromium.org gov...@chromium.org
-amineer
+govind

It's actually a non-Android change :)
Cc: abdulsyed@chromium.org
Before we approve merge to M58, could you please confirm CL listed at #1 is well baked/verified in Canary, having enough automation test coverage (I do see browsers and unit tests in cl) and safe to merge to M58?
According to omaha both the change and the revert made it into the same canary release 59.0.3034.0 so I don't think it will be possible to verify it on Canary as is :(

I can confirm the change in a local build and that it has enough coverage.
It disables part of an experiment on desktop so should be pretty harmless IMO.
Labels: -Merge-Review-58 Merge-Approved-58
Thank you  avayvod@.
Approving merge to M58 branch 3029 based on comment #9. Please merge ASAP. Thank you.
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 9 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c784820b54f8eeda51d9f02de7d2b9792894f34b

commit c784820b54f8eeda51d9f02de7d2b9792894f34b
Author: Anton Vayvod <avayvod@google.com>
Date: Thu Mar 09 21:47:11 2017

Disable pausing background video-only players on desktop.

The intent is to merge this to M58 to launch the background video
optimizations that do both pausing for video-only and disabling the
video track for audible videos.

BUG= 699106 
TEST=existing tests

Review-Url: https://codereview.chromium.org/2734963003
Cr-Commit-Position: refs/heads/master@{#455187}
(cherry picked from commit 60588ea13e075f43e47cd97d6911b8c50ce5d579)

Review-Url: https://codereview.chromium.org/2741083002 .
Cr-Commit-Position: refs/branch-heads/3029@{#93}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/c784820b54f8eeda51d9f02de7d2b9792894f34b/content/browser/media/session/media_session_impl_visibility_browsertest.cc
[modify] https://crrev.com/c784820b54f8eeda51d9f02de7d2b9792894f34b/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/c784820b54f8eeda51d9f02de7d2b9792894f34b/media/blink/webmediaplayer_impl_unittest.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment