ForceRecl |
||||||
Issue descriptionThere is a bug where the referenced surfaces gets updated after CompositorFrameSinkSupport::SubmitCompositorFrame() correctly then at the next LayerTreeHostImpl::BeginCommit() the references all get cleared. This only seems to happen when using DirectCompositorFrameSink, probably because MojoCompositorFrameSink doesn't have a ForceReclaimResources. The following stack trace roughly outlines the problem: SurfaceFactoryClient::ReferencedSurfacesChanged Surface::ActivateFrame Surface::QueueFrame Surface::EvictFrame SurfaceFactory::ClearSurface CompositorFrameSinkSupport::ForceReclaimResources DirectCompositorFrameSink::ForceReclaimResources LayerTreeHostImpl::BeginCommit This breaks the ability to use surface references for GC, since references may or may not exist depending on the timing. This effects normal Chrome which is using sequences + references to find the set of live surfaces There are enough SurfaceSequences being added to stop flashing on resize but I'd imagine this could cause some subtle problems.
,
Mar 21 2017
Ping @erick. Will you be looking at removing ForceReclaimResources soon or can we (Mus folks) poke at it? Thanks!
,
Apr 19 2017
,
Apr 23 2017
Kyle is getting rid of ForceReclaimResources so I'm assigning this back to him.
,
May 2 2017
ForceReclaimResources() is gone as of https://codereview.chromium.org/2822143003/.
,
Jun 13 2017
,
Feb 26 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fsam...@chromium.org
, Mar 7 2017