New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699099 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
no longer working on chrome
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Extend max duration of Media.Duration histogram

Project Member Reported by joh...@chromium.org, Mar 7 2017

Issue description

The existing Media.Duration histogram was capped at 1 hour, which is
exceeded by over 10% of videos.
 
I landed a replacement Media.Duration2 histogram in https://codereview.chromium.org/2731513002
445361c39af42d3d14152f10a2ae9c786d5d0c68 @{#454783} which extends the max duration to 24 hours.
Labels: Merge-Request-58
Requesting merge to 58. Safe UMA-only one-liner, and it'll be useful for other patches to get the new information 6 weeks earlier.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 8 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 8 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e9c208c85fde1b9902c8738c2010e3d93c822f0

commit 3e9c208c85fde1b9902c8738c2010e3d93c822f0
Author: John Mellor <johnme@chromium.org>
Date: Wed Mar 08 16:32:57 2017

Media: Add improved duration histogram

The existing Media.Duration histogram was capped at 1 hour, which is
exceeded by over 10% of videos.

BUG= 699099 

Review-Url: https://codereview.chromium.org/2731513002
Cr-Commit-Position: refs/heads/master@{#454783}
(cherry picked from commit 445361c39af42d3d14152f10a2ae9c786d5d0c68)

Review-Url: https://codereview.chromium.org/2735383002 .
Cr-Commit-Position: refs/branch-heads/3029@{#63}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/3e9c208c85fde1b9902c8738c2010e3d93c822f0/media/base/pipeline_impl.cc
[modify] https://crrev.com/3e9c208c85fde1b9902c8738c2010e3d93c822f0/tools/metrics/histograms/histograms.xml

Labels: M-58
Status: Fixed (was: Started)

Sign in to add a comment