The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/411333039edf0a1cfa7ecd505a979af3015545f2

commit 411333039edf0a1cfa7ecd505a979af3015545f2
Author: dvadym <dvadym@chromium.org>
Date: Tue Mar 14 12:15:00 2017

[Password Manager] Fix saving for accounts.google.com.

Saving on accounts.google.com doesn't work, the reasons are the following:

The sign-in form is loaded on https://accounts.google.com/ServiceLogin, but then when the submission is done, url is https://accounts.google.com/signin/v2/challenge/pwd , so loaded form and the submitted form are considered as different forms, and the Password Manager thinks that the submitted form was not seen during adding to DOM, and such forms are skipped since Password Manager can't fill forms that can't be seen (and no point to save password, that can't be filled). But this is legitimate site behaviour

This CL implements checking whether loaded and submitted forms come from the same frame (a frame is represented with a driver in Password Manager code).

BUG= 699097 

Review-Url: https://codereview.chromium.org/2740523002
Cr-Commit-Position: refs/heads/master@{#456674}

[modify] https://crrev.com/411333039edf0a1cfa7ecd505a979af3015545f2/chrome/browser/ui/login/login_handler.cc
[modify] https://crrev.com/411333039edf0a1cfa7ecd505a979af3015545f2/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/411333039edf0a1cfa7ecd505a979af3015545f2/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/411333039edf0a1cfa7ecd505a979af3015545f2/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/411333039edf0a1cfa7ecd505a979af3015545f2/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/411333039edf0a1cfa7ecd505a979af3015545f2/components/password_manager/core/browser/password_manager.h
[modify] https://crrev.com/411333039edf0a1cfa7ecd505a979af3015545f2/components/password_manager/core/browser/password_manager_unittest.cc

Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Tested on mac os 10.12.3 using chrome M59 #59.0.3046.0 and followed below steps :

1. Launched chrome and navigated to "https://accounts.google.com/ServiceLogin" and signed into google account and observed that password bubble appears.
2. once password bubble save option is clciked , password is saved in chrome://settings /passwords.

Attached screencast for reference.

@dvadym-- could you please check attached screencast and please help us to verify the issue by providing repro manual steps .

Thanks!

Deleted: 699097.mp4 2.1 MB

	699097.mp4 2.1 MB View Download

Thanks hdodda@, the screencast contains steps to check that the fix works.
Also, could you please check one more case?
1.Login in accounts.google.com, but don't save a password. And then sign-out.
2.Then go to accounts.google.com again, e-mail will be filled by the site, and only a password should be typed. 
3.Then could you please type password and check that a save prompt is shown?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5083384086d0a831786ccd7c6a9ee55d4ca85ef3

commit 5083384086d0a831786ccd7c6a9ee55d4ca85ef3
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Mon Mar 20 11:59:15 2017

[Merge to M-58] [Password Manager] Fix saving for accounts.google.com.

Saving on accounts.google.com doesn't work, the reasons are the following:

The sign-in form is loaded on https://accounts.google.com/ServiceLogin, but then when the submission is done, url is https://accounts.google.com/signin/v2/challenge/pwd , so loaded form and the submitted form are considered as different forms, and the Password Manager thinks that the submitted form was not seen during adding to DOM, and such forms are skipped since Password Manager can't fill forms that can't be seen (and no point to save password, that can't be filled). But this is legitimate site behaviour

This CL implements checking whether loaded and submitted forms come from the same frame (a frame is represented with a driver in Password Manager code).

BUG= 699097 

Review-Url: https://codereview.chromium.org/2740523002
Cr-Commit-Position: refs/heads/master@{#456674}
(cherry picked from commit 411333039edf0a1cfa7ecd505a979af3015545f2)

Review-Url: https://codereview.chromium.org/2760883002 .
Cr-Commit-Position: refs/branch-heads/3029@{#293}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/5083384086d0a831786ccd7c6a9ee55d4ca85ef3/chrome/browser/ui/login/login_handler.cc
[modify] https://crrev.com/5083384086d0a831786ccd7c6a9ee55d4ca85ef3/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/5083384086d0a831786ccd7c6a9ee55d4ca85ef3/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/5083384086d0a831786ccd7c6a9ee55d4ca85ef3/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/5083384086d0a831786ccd7c6a9ee55d4ca85ef3/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/5083384086d0a831786ccd7c6a9ee55d4ca85ef3/components/password_manager/core/browser/password_manager.h
[modify] https://crrev.com/5083384086d0a831786ccd7c6a9ee55d4ca85ef3/components/password_manager/core/browser/password_manager_unittest.cc

Verified on Mac os 10.12.3 , Ubuntu 14.04 and Windows 7 using chrome M59 #59.0.3047.0 and issue is fixed .

Followed steps as per comment #5 and attached screencast for reference.

Adding TE-Verified labels.

Thanks!

Deleted: 699097_1.mp4 1.6 MB

	699097_1.mp4 1.6 MB View Download

Thanks for verifying!

Verified on Mac os 10.12.3 , Ubuntu 14.04 and Windows 7 using chrome M58 #58.0.3029.33 and issue is fixed .

Followed steps as per comment #5 and working as expected as attached screenshot in comment #7.

Adding TE-Verified labels.

Thanks!