Play instead of pause button in media/controls-drag-timebar-rendering.html |
||||
Issue descriptionIssue 359522 was a bug where media elements in playing mode (|| icon) were sometimes incorrectly rendered as paused mode (|> icon). It was fixed by https://codereview.chromium.org/239113003 (r171706), which added the test media/controls-drag-timebar-rendering.html. Unfortunately, whilst this test is passing, it's passing for the wrong reason. The playing mode (|| icon) does in fact get incorrectly rendered as paused mode (|> icon) during the test, and the test only passes because the current time displayed doesn't get updated when scrubbing paused videos. It's not clear the test was always testing the wrong thing, or whether the test silently switched from testing the right thing to testing the wrong thing at some point as is unfortunately quite easy for expected-mismatch tests.
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/792dd3474f7076b0dc33126a90ba4affbaac2c7f commit 792dd3474f7076b0dc33126a90ba4affbaac2c7f Author: johnme <johnme@chromium.org> Date: Tue Mar 07 18:50:00 2017 Media Controls timeline: immediately update current time display Before this patch, dragging the scrubber starting from its current position would immediately update the current time display, but all other ways of changing the scrubber (dragging from some other start position, click on a position, or using the keyboard) would only update the current time display once the media had finished seeking to the desired position (which might have to wait for network requests). This patch removes that distinction, and now immediately updates the current time display whenever the timeline receives input. This should make it easier to precisely set the current time. BUG= 695459 ,699096 Review-Url: https://codereview.chromium.org/2725893002 Cr-Commit-Position: refs/heads/master@{#455158} [modify] https://crrev.com/792dd3474f7076b0dc33126a90ba4affbaac2c7f/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/792dd3474f7076b0dc33126a90ba4affbaac2c7f/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp [modify] https://crrev.com/792dd3474f7076b0dc33126a90ba4affbaac2c7f/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp
,
Mar 12 2017
foolip@ any chance you can have a look or leave some feedback that could help someone else to have a look?
,
Mar 20 2017
In some manual testing, it seems like the user-visible behavior is at least still correct, whether playing or paused, dragging the time slider doesn't cause the play/pause button state to flicker. Attaching the actual results from running the test locally. Because it's an -expected-mismatch.html test, failure means that this is also what the reference looked like.
,
Mar 20 2017
In other words, unlike my manual testing, it looks like the icon is in the wrong state in this test. To investigate, I would see if the early return in MediaControls::updatePlayState() is being taken in this test. If not, that would be a problem. I would check if MediaControlPlayButtonElement::defaultEventHandler() calling updateDisplayType() directly and not going through MediaControls::updatePlayState() could be related. Marking as available.
,
Dec 18 2017
FYI, this test just flaked for me in a try-bot run: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/610900 (The try run is just modifying some GN and waterfall rules, not code).
,
Dec 19
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 10
FYI, https://crrev.com/c/840617 removed the lines from TestExpectations that were referencing this bug some time ago. You may be able to close it now (I'm just doing a bulk update, I have not looked at the details of each test). |
||||
►
Sign in to add a comment |
||||
Comment 1 by joh...@chromium.org
, Mar 7 2017