Issue metadata
Sign in to add a comment
|
17%-520.9% regression in webrtc_perf_tests at 17073:17073 |
||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 7 2017
Looks like changing the order in which tests run cause values from different tests to be used to track the same metric. For example: WebRTCPerf/webrtc-android-tests-nexus5-kitkat/webrtc_perf_tests/ramp_up_down_up_1stream_rtx/first_rampup Build 1271: https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28K%20Nexus5%29/builds/1271 The tests which produce an output for the metric "ramp_up_down_up_1stream_rtx" is reported in this order: [ RUN ] RampUpTest.UpDownUpAudioTransportSequenceNumberRtx RESULT ramp_up_down_up_1stream_rtx: first_rampup= 13 ms [ RUN ] RampUpTest.UpDownUpTransportSequenceNumberPacketLoss RESULT ramp_up_down_up_1stream_rtx: first_rampup= 94 ms Build 1272: https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28K%20Nexus5%29/builds/1272 The tests run in this order instead: [ RUN ] RampUpTest.UpDownUpTransportSequenceNumberPacketLoss RESULT ramp_up_down_up_1stream_rtx: first_rampup= 106 ms [ RUN ] RampUpTest.UpDownUpAudioTransportSequenceNumberRtx RESULT ramp_up_down_up_1stream_rtx: first_rampup= 13 ms Is this working as intended?
,
Mar 7 2017
I'm not sure I'm following what's right/wrong here. The perf dashboard doesn't know anything about the test in which the perf metric is reported (and it shouldn't), since it's perfectly fine if a perf test doesn't even use gtest. It only categorizes the data points using the test executable name and the identifiers printed after the RESULT line. So it seems like the problem here is to make sure each entry printed has a unique name, to avoid mixing them together
,
Mar 7 2017
Removing R-V-G label (was set upon bug filing because the bot was incorrectly configured as internal)
,
Mar 7 2017
Stefan, looks like the test UpDownUpTransportSequenceNumberPacketLoss (added in https://codereview.webrtc.org/2705603002) report the same metric as UpDownUpAudioTransportSequenceNumberRtx. Now the order of those two tests have changed so now certain metrics use the result from one test instead of the other.
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/45b5fe549f9bea7a4abc9932937b6c35ad5adc54 commit 45b5fe549f9bea7a4abc9932937b6c35ad5adc54 Author: stefan <stefan@webrtc.org> Date: Thu Mar 09 14:27:02 2017 Don't report perf metrics for packet loss ramp-up tests. BUG= chromium:699072 Review-Url: https://codereview.webrtc.org/2744603002 Cr-Commit-Position: refs/heads/master@{#17145} [modify] https://crrev.com/45b5fe549f9bea7a4abc9932937b6c35ad5adc54/webrtc/call/rampup_tests.cc [modify] https://crrev.com/45b5fe549f9bea7a4abc9932937b6c35ad5adc54/webrtc/call/rampup_tests.h
,
Mar 15 2017
Metrics back down -- added to the report at the top of this bug.
,
Mar 15 2017
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by philipel@chromium.org
, Mar 7 2017