New issue
Advanced search Search tips

Issue 699063 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jan 7
Cc:
f...@opera.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebVTT line should be stored as a double-precision float

Project Member Reported by zcorpan@gmail.com, Mar 7 2017 
It's stored as a single-precision float currently, but the API uses double and the specification's parsing rules accepts finite double-precision values. Although it makes little sense to actually use such big (or precise) numbers, it can be annoying to run into rounding differences between implementations if some use single-precision and others use double-precision.

Tests: https://github.com/w3c/web-platform-tests/pull/5062

Comment 1 by f...@opera.com, Mar 7 2017

Status: Available (was: Untriaged)

Comment 2 by k2.nagar...@samsung.com, Dec 21 2017 

started working on this issue.
pushed WIP patch
https://chromium-review.googlesource.com/c/chromium/src/+/836576
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbdca255c3f886b43912e28e012e016334a8853c

commit fbdca255c3f886b43912e28e012e016334a8853c
Author: k2.nagaraju <k2.nagaraju@samsung.com>
Date: Tue Jan 02 13:11:56 2018

WebVTT line, position and size cue properties stored as double

updated the line, position and size properties to double
updated test cases and expected results

Bug:  699063 
Change-Id: Icc179032077e0e1351efed64cc5a965ee254ca09
Reviewed-on: https://chromium-review.googlesource.com/836576
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#526469}
[modify] https://crrev.com/fbdca255c3f886b43912e28e012e016334a8853c/third_party/WebKit/LayoutTests/external/wpt/webvtt/parsing/file-parsing/tests/settings-line-expected.txt
[modify] https://crrev.com/fbdca255c3f886b43912e28e012e016334a8853c/third_party/WebKit/LayoutTests/media/track/vtt-cue-float-precision.html
[modify] https://crrev.com/fbdca255c3f886b43912e28e012e016334a8853c/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
[modify] https://crrev.com/fbdca255c3f886b43912e28e012e016334a8853c/third_party/WebKit/Source/core/html/track/vtt/VTTCue.h
[modify] https://crrev.com/fbdca255c3f886b43912e28e012e016334a8853c/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp
[modify] https://crrev.com/fbdca255c3f886b43912e28e012e016334a8853c/third_party/WebKit/Source/core/html/track/vtt/VTTParser.h
[modify] https://crrev.com/fbdca255c3f886b43912e28e012e016334a8853c/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
[modify] https://crrev.com/fbdca255c3f886b43912e28e012e016334a8853c/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.h
[modify] https://crrev.com/fbdca255c3f886b43912e28e012e016334a8853c/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp
[modify] https://crrev.com/fbdca255c3f886b43912e28e012e016334a8853c/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h
[modify] https://crrev.com/fbdca255c3f886b43912e28e012e016334a8853c/third_party/WebKit/Source/core/html/track/vtt/VTTScannerTest.cpp
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 2

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by f...@opera.com, Jan 7

Status: Fixed (was: Untriaged)
►

Sign in to add a comment