New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699027 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[UserClassifier] Add a unit-test

Project Member Reported by jkrcal@chromium.org, Mar 7 2017

Issue description

UserClassifier has no test coverage. Fix it.
 

Comment 1 Deleted

Please

Comment 3 by fi...@chromium.org, Mar 14 2017

Labels: M-59 zine-triaged

Comment 4 by jkrcal@chromium.org, Mar 21 2017

Status: Started (was: Assigned)
On top of that:
 - UserClassifier should be injected into content_suggestions_service.
 - UserClassifier is created in a lot of tests, the code-duplication should be minimized.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afbbf48b9c592f0e857bb5bba9179c925b24bf01

commit afbbf48b9c592f0e857bb5bba9179c925b24bf01
Author: jkrcal <jkrcal@chromium.org>
Date: Wed Mar 22 09:46:56 2017

[User classifier] Add a unit-test

This CL adds basic test support for UserClassifier. More advance tests
may follow.

BUG= 699027 

Review-Url: https://codereview.chromium.org/2761313002
Cr-Commit-Position: refs/heads/master@{#458701}

[modify] https://crrev.com/afbbf48b9c592f0e857bb5bba9179c925b24bf01/components/ntp_snippets/BUILD.gn
[add] https://crrev.com/afbbf48b9c592f0e857bb5bba9179c925b24bf01/components/ntp_snippets/user_classifier_unittest.cc

Comment 7 by jkrcal@chromium.org, Apr 10 2017

Labels: -Pri-1 -M-59 M-60 Pri-2
Most of the work is done. Decreasing the prio for further unit-tests and pushing them to M60.

Comment 8 by jkrcal@chromium.org, Nov 27 2017

Status: WontFix (was: Started)
Not important any more.

Sign in to add a comment