Issue metadata
Sign in to add a comment
|
Regression: Unnecessary size of Search box on NTP is increased after closing preview page.
Reported by
rk...@etouch.net,
Mar 7 2017
|
||||||||||||||||||||||
Issue descriptionVersion: 58.0.3029.6 610f4595f8ea01904e3d01506c41201a816dc338-refs/branch-heads/3029@{#35} OS: Windows (7,8,8.1,10),Linux (14.04 LTS) What steps will reproduce the problem? (1) Launch chrome, open NTP and zoomed in upto 150% (2) Give print (Ctrl+P)command, cancel preivew page and observe search box Actual: Unnecessary size of Search box on NTP is increased after closing preview page. Expected: Search box on NTP should seen properly. This is regression issue, broken in ‘M 57’ and will soon update other info : Good build:57.0.2953.0 Bad build: 57.0.2955.0 Note: Issue is not seen on Mac OS.
,
Mar 7 2017
Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/6a87148dbee3293f14f151d94b760798e1768068..90d4ea3d543f0031769b3aacac2d3e084b95fb7d?pretty=fuller&n=100 Suspecting: r439092 @rune: Please help me to reassign this issue if your change is not cause for it.
,
Mar 7 2017
Normal Bisect was provided as per revision bisect generated only Bad builds.
,
Mar 7 2017
Adding Release block label, please undo if not the case.
,
Mar 9 2017
,
Mar 9 2017
Thanks for the fix , we will verify in today's canary and if all looks good, please request a merge to M58.
,
Mar 10 2017
Hasn't landed yet ...
,
Mar 10 2017
Just to update: Issue is not fixed on latest build 59.0.3037.0 Thank you.
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de209f3db7bbfda754be262cef35b67340c37774 commit de209f3db7bbfda754be262cef35b67340c37774 Author: rune <rune@opera.com> Date: Fri Mar 10 11:12:13 2017 Initial containing block for print not affected by page zoom. The page zoom factor is not applied to the ICB for printing, yet the ICB basis for media queries and viewport units were. Use 1 as a page zoom factor in viewportSizeForViewportUnits and use that method to get the size for the ICB for evaluating media queries. BUG= 699014 , 699910 Review-Url: https://codereview.chromium.org/2738173002 Cr-Commit-Position: refs/heads/master@{#456040} [modify] https://crrev.com/de209f3db7bbfda754be262cef35b67340c37774/third_party/WebKit/Source/core/css/MediaValues.cpp [modify] https://crrev.com/de209f3db7bbfda754be262cef35b67340c37774/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/de209f3db7bbfda754be262cef35b67340c37774/third_party/WebKit/Source/core/frame/FrameView.h [modify] https://crrev.com/de209f3db7bbfda754be262cef35b67340c37774/third_party/WebKit/Source/web/tests/WebViewTest.cpp
,
Mar 10 2017
,
Mar 10 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-58; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-58 label, otherwise remove Merge-TBD label. Thanks.
,
Mar 13 2017
Please request a merge to M58 if cl listed at #10 looks good in Canary and remove "Merge-TBD" label. Thank you.
,
Mar 13 2017
,
Mar 13 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9bf08c7035e4fb55adc870418679bb003034d2b commit e9bf08c7035e4fb55adc870418679bb003034d2b Author: Rune Lillesveen <rune@opera.com> Date: Mon Mar 13 23:11:47 2017 Initial containing block for print not affected by page zoom. The page zoom factor is not applied to the ICB for printing, yet the ICB basis for media queries and viewport units were. Use 1 as a page zoom factor in viewportSizeForViewportUnits and use that method to get the size for the ICB for evaluating media queries. BUG= 699014 , 699910 Review-Url: https://codereview.chromium.org/2738173002 Cr-Commit-Position: refs/heads/master@{#456040} (cherry picked from commit de209f3db7bbfda754be262cef35b67340c37774) Review-Url: https://codereview.chromium.org/2752543002 . Cr-Commit-Position: refs/branch-heads/3029@{#173} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/e9bf08c7035e4fb55adc870418679bb003034d2b/third_party/WebKit/Source/core/css/MediaValues.cpp [modify] https://crrev.com/e9bf08c7035e4fb55adc870418679bb003034d2b/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/e9bf08c7035e4fb55adc870418679bb003034d2b/third_party/WebKit/Source/core/frame/FrameView.h [modify] https://crrev.com/e9bf08c7035e4fb55adc870418679bb003034d2b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
,
Mar 14 2017
Tested the issue on Windows-7,and Linux Ubuntu 14.04 using chrome version#58.0.3029.19 with the attached repro test case from comment#5 Observed that the fix is working as expected. Hence adding TE-Verified labels. Please find the attached screen cast for the same. Thanks!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by treib@chromium.org
, Mar 7 2017Components: Internals>Printing
Labels: -Pri-1 Pri-2