Improve form matching and filling with valid crowdsourced field types |
||
Issue descriptionChrome Version: 59.0.3033.0 (dev branch) OS: Win 7 We have few examples of websites where the autofill fails to fill the form. Found problems described below: 1. If the heuristics failed but the crowdsourcing server returned valid field types, autofill can fail to update its form cache properly. There are few problems with the form matching and autofillable field count updating. 2. Some forms can have an <option> value attribute with the length of more than 1024. This value is not visible to the user (user sees content) but it can be used internally to pass some data to JS-backed logic. It's perfectly valid but the autofill logic bans it for unknown reason.
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7eaf2657fde72f7cc64482cfb0d701bbaf34648a commit 7eaf2657fde72f7cc64482cfb0d701bbaf34648a Author: sense <sense@yandex-team.ru> Date: Tue Mar 14 15:34:51 2017 Improve autofill form matching. * Fix form updating logic if the field heuristics failed but the server returned correct field types. * Remove the check for the <option> value attribute length because some websites can use it as a storage for JS-backed logic. * Add form matching using form_signature, this improves matching of forms with the empty action attribute. BUG= 699004 TEST=components_unittests --gtest_filter=Autofill* R=vabr@chromium.org, mathp@chromium.org Review-Url: https://codereview.chromium.org/2730383003 Cr-Commit-Position: refs/heads/master@{#456707} [modify] https://crrev.com/7eaf2657fde72f7cc64482cfb0d701bbaf34648a/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/7eaf2657fde72f7cc64482cfb0d701bbaf34648a/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/7eaf2657fde72f7cc64482cfb0d701bbaf34648a/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/7eaf2657fde72f7cc64482cfb0d701bbaf34648a/components/autofill/core/browser/form_structure.cc [modify] https://crrev.com/7eaf2657fde72f7cc64482cfb0d701bbaf34648a/components/autofill/core/browser/form_structure.h [modify] https://crrev.com/7eaf2657fde72f7cc64482cfb0d701bbaf34648a/components/autofill/core/common/autofill_data_validation.cc
,
Mar 15 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by se...@yandex-team.ru
, Mar 7 2017