New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 699000 link

Starred by 7 users
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Aug 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ ananta@chromium.org
nyerramilli@chromium.org
thestig@chromium.org
rbasuvula@chromium.org
█ brajkumar@chromium.org
█ msrchandra@chromium.org
dpa...@chromium.org
rbpotter@chromium.org
█ dschuyler@chromium.org
█ ranjitkan@chromium.org
halcanary@chromium.org
hcarmona@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Disallow link clicks in print preview

Reported by mni...@etouch.net, Mar 7 2017 
Version: 58.0.3029.6 610f4595f8ea01904e3d01506c41201a816dc338-refs/branch-heads/3029@{#35}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/content/notifications and click on 'Add' button in front of 'Allow'
2. Now press 'Ctrl + P' to open print preview and try to hover mouse above 'Current incognito session only' message or anywhere over 'Add exception for a site' overlay until hand pointer is seen and click it,observe

Actual: Unnecessary 'Google Drive' gets open in NTP after clicking on print preview 
Expected: Unnecessary 'Google Drive' should not get open in NTP after clicking on print preview  

This is regression issue, broken in ‘M 54’ and will soon update other info :
Good build:54.0.2827.0
Bad build: 54.0.2829.0
Actual_video.mp4
712 KB View Download
Expected_video.mp4
584 KB View Download

Comment 1 by rbasuvula@chromium.org, Mar 7 2017

Cc: rbasuvula@chromium.org
Labels: has-bisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:54.0.2827.0 (Revision: 411497).
Bad build:54.0.2829.0  (Revision: 411902).

You are probably looking for a change made after 411764 (known good), but no later than 411765 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/0b8904601897107f297027eecbb7572bb7bf902d..b1172d1d706568e8f33178e72735b2480fcbaf22

From the CL above, assigning the issue to the concern owner

@dschuyler : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2240023002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Stable # 56.0.2924.87, Beta #57.0.2924.88 Canary #58.0.3032.0

Comment 2 by dschuyler@chromium.org, Mar 14 2017

Labels: -Pri-2 Pri-3

Comment 3 by dschuyler@chromium.org, May 18 2017

Owner: rbpotter@chromium.org
Hi Rebecca, this is one of those "click in the print preview" bugs. IIRC, groby@, you and I were chatting about whether print preview should not respond to clicks in the preview (or at least not act like a mini version of the page shown).

If there's already a bug for putting a click-blocker on the preview, please dupe this to that; if not, maybe this bug could become the "put a click-blocker on the preview" bug.

Comment 4 by rbpotter@chromium.org, Jun 26 2017

Cc: rbpotter@chromium.org thestig@chromium.org dpa...@chromium.org
Labels: -Pri-3 -Type-Bug-Regression -M-58 -has-bisect-per-revision Pri-2 Type-Bug
Owner: ----
Status: Available (was: Assigned)
Summary: Disallow link clicks in print preview (was: Regression : Unnecessary 'Google Drive' gets open in NTP in chrome://md-settings/content/notifications.)
Per comment 3, changing this to a tracking bug for removing the ability to click links within the print preview preview area (i.e. inside the previewed document).

Currently, some links are clickable in print preview and others are not, and we have had bugs filed both about clickable links no longer working and non-clickable links suddenly working. In general, navigating to a new page from the print preview seems like an unexpected behavior. We should add a click blocker to prevent links in the preview area from opening other pages.

Comment 5 by rbpotter@chromium.org, Jun 26 2017

Cc: ajha@chromium.org kavvaru@chromium.org brajkumar@chromium.org
 Issue 719443  has been merged into this issue.

Comment 6 by dpa...@chromium.org, Jul 5 2017

Cc: hcarmona@chromium.org
 Issue 739324  has been merged into this issue.

Comment 7 by rbpotter@chromium.org, Jul 27 2017 

 Issue 663637  has been merged into this issue.

Comment 8 by rbpotter@chromium.org, Jul 27 2017

Cc: halcanary@chromium.org ananta@chromium.org dschuyler@chromium.org
 Issue 645012  has been merged into this issue.

Comment 9 by rbpotter@chromium.org, Aug 16 2017

Components: -UI>Settings
Owner: rbpotter@chromium.org
Status: Started (was: Available)
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b96dcc112f56bf4a48ca7ede5e7a03cb965a045b

commit b96dcc112f56bf4a48ca7ede5e7a03cb965a045b
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Aug 18 00:44:47 2017

Remove link clicks in print preview

Bug:  699000 
Change-Id: I7bce7da8c612fe5c98255d6eb0e69f4d42132e55
Reviewed-on: https://chromium-review.googlesource.com/618300
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495397}
[modify] https://crrev.com/b96dcc112f56bf4a48ca7ede5e7a03cb965a045b/pdf/pdfium/pdfium_engine.cc

Comment 11 by rp...@etouch.net, Aug 21 2017

Labels: TE-Verified-62.0.3192.0 TE-Verified-M62
Rechecked the above issue on Windows OS with latest canary chrome version : 62.0.3192.0 and the issue is not reproducible.Kindly refer the attached screen cast.
Actual_video.mp4
477 KB View Download

Comment 12 by rbpotter@chromium.org, Aug 21 2017

Status: Fixed (was: Started)

Comment 13 by rbpotter@chromium.org, Jun 26 2018 

 Issue 724443  has been merged into this issue.
►

Sign in to add a comment