New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 698994 link

Starred by 1 user
Status: Fixed
Owner:
█ wkorman@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
█ trchen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

PaintArtifactCompositorTestWithPropertyTrees.UpdateProducesNewSequenceNumber fails in blink_platform_unittests

Project Member Reported by toyoshim@chromium.org, Mar 7 2017 
When I run blink_platform_unittests, PaintArtifactCompositorTestWithPropertyTrees.UpdateProducesNewSequenceNumber always fail in the first run, and pass in a retry.

Also, the test passes if I specify the exact test name with --gtest_filter. I guess previous test leaks side effects and the next test, UpdateProducesNewSequenceNumber, fails.

% ./out/Release/blink_platform_unittests --gtest_filter='PaintArtifactCompositorTestWithPropertyTrees.*'
(snip)
[ RUN      ] PaintArtifactCompositorTestWithPropertyTrees.UpdateProducesNewSequenceNumber
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1794: Failure
Value of: propertyTrees().sequence_number
  Actual: 4
Expected: 1
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1796: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 4
Expected: 1
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1796: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 4
Expected: 1
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1796: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 4
Expected: 1
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1796: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 4
Expected: 1
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1796: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 4
Expected: 1
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1802: Failure
Value of: propertyTrees().sequence_number
  Actual: 5
Expected: 2
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1804: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 5
Expected: 2
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1804: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 5
Expected: 2
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1804: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 5
Expected: 2
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1804: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 5
Expected: 2
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1804: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 5
Expected: 2
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1810: Failure
Value of: propertyTrees().sequence_number
  Actual: 6
Expected: 3
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1812: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 6
Expected: 3
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1812: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 6
Expected: 3
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1812: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 6
Expected: 3
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1812: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 6
Expected: 3
../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:1812: Failure
Value of: layer->property_tree_sequence_number()
  Actual: 6
Expected: 3
[  FAILED  ] PaintArtifactCompositorTestWithPropertyTrees.UpdateProducesNewSequenceNumber (1 ms)
[

Comment 1 by toyoshim@chromium.org, Mar 7 2017

Owner: wkorman@chromium.org
Status: Assigned (was: Untriaged)
let me assign wkorman from a result of git annotate platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Comment 2 by wkorman@chromium.org, Mar 7 2017

Cc: trchen@chromium.org
Sorry about this, trchen@ mentioned it to me today as well, I will look at tomorrow.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64f24e7d5bd2de951756aa0bd6595dc2d8a3ba8b

commit 64f24e7d5bd2de951756aa0bd6595dc2d8a3ba8b
Author: wkorman <wkorman@chromium.org>
Date: Thu Mar 09 18:08:26 2017

De-flake property sequence number unit test.

BUG= 698994 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2743573002
Cr-Commit-Position: refs/heads/master@{#455791}

[modify] https://crrev.com/64f24e7d5bd2de951756aa0bd6595dc2d8a3ba8b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Comment 4 by wkorman@chromium.org, Mar 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment