Sebastien, how should we do about the setting and close buttons on pinned notification? Before we introduce the setting button, pinned notifications didn't show the close button at all, since pinned notifications can't be removed by user.

I think there are 3 options.

1. Remove the close button and Move the setting button to the rightmost

2. Keep the place of the setting button and Make the close button invisible

3. Keep the place of the setting button and Make the close button grayed and disabled

4. Any other idea?

Let's go with #1. Thanks!

Thanks, Sebastien.

Hanada-san, could you go with #1? Thanks.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c995cd504967cbdead7960097409835d6efde089

commit c995cd504967cbdead7960097409835d6efde089
Author: yhanada <yhanada@chromium.org>
Date: Fri Mar 10 06:24:59 2017

Show the settings button on a pinned notification.

Also some redundant code is removed.

BUG= 698986 

Review-Url: https://codereview.chromium.org/2734933006
Cr-Commit-Position: refs/heads/master@{#456008}

[modify] https://crrev.com/c995cd504967cbdead7960097409835d6efde089/ui/arc/notification/arc_custom_notification_view.cc
[modify] https://crrev.com/c995cd504967cbdead7960097409835d6efde089/ui/arc/notification/arc_custom_notification_view.h
[modify] https://crrev.com/c995cd504967cbdead7960097409835d6efde089/ui/message_center/views/padded_button.cc

Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/101d332281f35b1ac45e991a31b19f13707f8808

commit 101d332281f35b1ac45e991a31b19f13707f8808
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Thu Mar 16 06:26:28 2017

Show the settings button on a pinned notification.

Also some redundant code is removed.

BUG= 698986 

Review-Url: https://codereview.chromium.org/2734933006
Cr-Commit-Position: refs/heads/master@{#456008}
(cherry picked from commit c995cd504967cbdead7960097409835d6efde089)

Review-Url: https://codereview.chromium.org/2749943004 .
Cr-Commit-Position: refs/branch-heads/3029@{#229}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/101d332281f35b1ac45e991a31b19f13707f8808/ui/arc/notification/arc_custom_notification_view.cc
[modify] https://crrev.com/101d332281f35b1ac45e991a31b19f13707f8808/ui/arc/notification/arc_custom_notification_view.h
[modify] https://crrev.com/101d332281f35b1ac45e991a31b19f13707f8808/ui/message_center/views/padded_button.cc

I merged on behalf of yhanada@.

Thank you!