Issue metadata
Sign in to add a comment
|
ChromeOS captive portal dialog crashes when the login page shows a modal dialog (SimpleWebViewDialog) |
||||||||||||||||||||||||
Issue descriptionChrome Version: 58, but probably earlier too OS: ChromeOS What steps will reproduce the problem? (1) Change CaptivePortalDetector::kDefaultURL to http://www.meacer.com/captive_portal.html and build Chrome on ChromeOS (2) On the login page, click "visit the network's signin page" (3) Click "submit" button which alert()s a message. What is the expected result? alert() dialog appears What happens instead? Crash It looks like SimpleWebViewDialog doesn't properly handle alert/confirm/prompt dialogs. Restricting view as this can be used to DoS users who connect to captive portals.
,
Mar 7 2017
I think they are related but separate - meacer@ can confirm.
,
Mar 7 2017
They are separate issues, but I ran into this while testing bug 680329. Copying from comment #19 of that bug: "I'm still looking into returning the proper webcontents from SimpleWebViewDialog. Doing that revelead bug 698438 and other problems though: The location bar and omnibox code reference nonexistant objects which results in crashes. This is because there is no browser instance for SimpleWebViewDialog, and no TabsHelper, which creates some of these WebContentsUserData objects (ExtensionTabHelper, ChromeTranslateClient, ManagePasswordsUIController, FaviconDriver, SearchTabHelper etc). ..."
,
Mar 7 2017
Sorry for the false alarm: I realized this is because of a change I made for bug 699197 that I haven't landed yet, so there is no crash happening today (I changed SimpleWebviewDialog's GetWebContents to return webview->webcontents()). Without that, alert dialogs simply aren't displayed. Since there is no immediate problem here, I'm duping this into that bug. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Mar 7 2017