New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698933 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Add Precache.Fetch.ResponseBytes.Daily

Project Member Reported by twif...@chromium.org, Mar 7 2017

Issue description

This should measure how much of the daily_quota_total is used, allowing us to predict what the effects will be if we tweak that parameter.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd9e5cd40b36a72ab0803325f3d3910c90c84ec5

commit fd9e5cd40b36a72ab0803325f3d3910c90c84ec5
Author: twifkak <twifkak@chromium.org>
Date: Wed Mar 08 01:26:47 2017

Add Precache.Fetch.ResponseBytes.Daily.

This measures how much of the daily_quota_total is used, allowing us to
predict what the effects will be if we tweak that parameter.

BUG= 698933 

Review-Url: https://codereview.chromium.org/2735923002
Cr-Commit-Position: refs/heads/master@{#455323}

[modify] https://crrev.com/fd9e5cd40b36a72ab0803325f3d3910c90c84ec5/components/precache/core/precache_fetcher.cc
[modify] https://crrev.com/fd9e5cd40b36a72ab0803325f3d3910c90c84ec5/components/precache/core/proto/quota.proto
[modify] https://crrev.com/fd9e5cd40b36a72ab0803325f3d3910c90c84ec5/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 8 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 8 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50d2174d98bdd36b822c80ab23b7d838bd27561a

commit 50d2174d98bdd36b822c80ab23b7d838bd27561a
Author: Devin Mullins <twifkak@google.com>
Date: Wed Mar 08 21:16:01 2017

Add Precache.Fetch.ResponseBytes.Daily.

This measures how much of the daily_quota_total is used, allowing us to
predict what the effects will be if we tweak that parameter.

BUG= 698933 

Review-Url: https://codereview.chromium.org/2735923002
Cr-Commit-Position: refs/heads/master@{#455323}
(cherry picked from commit fd9e5cd40b36a72ab0803325f3d3910c90c84ec5)

Review-Url: https://codereview.chromium.org/2736323002 .
Cr-Commit-Position: refs/branch-heads/3029@{#69}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/50d2174d98bdd36b822c80ab23b7d838bd27561a/components/precache/core/precache_fetcher.cc
[modify] https://crrev.com/50d2174d98bdd36b822c80ab23b7d838bd27561a/components/precache/core/proto/quota.proto
[modify] https://crrev.com/50d2174d98bdd36b822c80ab23b7d838bd27561a/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment