New issue
Advanced search Search tips

Issue 698926 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 563714

Blocking:
issue 682490



Sign in to add a comment

Expand some Linux/NVIDIA workarounds to Android/NVIDIA

Project Member Reported by kainino@chromium.org, Mar 7 2017

Issue description

We need to expand the pack_parameters_workaround_with_pack_buffer workaround to also cover Android/NVIDIA in addition to Linux/NVIDIA.

This should allow passing conformance2/reading/read-pixels-pack-parameters.html on SHIELD and other Tegra devices.
 
Blocking: 682490
Need to also expand unpack_alignment_workaround_with_unpack_buffer workaround.

This allows passing conformance2/textures/misc/tex-unpack-params.html.
Summary: Expand some Linux/NVIDIA workarounds to Android/NVIDIA (was: Expand pack_parameters_workaround_with_pack_buffer workaround to Android/NVIDIA)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08e70dd3bd712e9d57a420c34e98b4eaef25599f

commit 08e70dd3bd712e9d57a420c34e98b4eaef25599f
Author: kainino <kainino@chromium.org>
Date: Wed Mar 08 07:09:38 2017

Expand 2 Linux/NVIDIA workarounds to Android/NVIDIA

pack_parameters_workaround_with_pack_buffer fixes
conformance2/reading/read-pixels-pack-parameters.html

unpack_alignment_workaround_with_unpack_buffer fixes
conformance2/textures/misc/tex-unpack-params.html

BUG= 698926 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2735823003
Cr-Commit-Position: refs/heads/master@{#455394}

[modify] https://crrev.com/08e70dd3bd712e9d57a420c34e98b4eaef25599f/gpu/config/gpu_driver_bug_list_json.cc

Status: Fixed (was: Started)
Labels: Merge-Request-58
This very small JSON change is needed to pass WebGL 2.0.0 on Android/NVIDIA. Requesting merge back to M58.
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 8 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 8 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93add423f47d3609dfeb2f1e49776d0d54ac69bb

commit 93add423f47d3609dfeb2f1e49776d0d54ac69bb
Author: Kai Ninomiya <kainino@chromium.org>
Date: Wed Mar 08 23:41:49 2017

Expand 2 Linux/NVIDIA workarounds to Android/NVIDIA

pack_parameters_workaround_with_pack_buffer fixes
conformance2/reading/read-pixels-pack-parameters.html

unpack_alignment_workaround_with_unpack_buffer fixes
conformance2/textures/misc/tex-unpack-params.html

BUG= 698926 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2735823003
Cr-Commit-Position: refs/heads/master@{#455394}
(cherry picked from commit 08e70dd3bd712e9d57a420c34e98b4eaef25599f)

Review-Url: https://codereview.chromium.org/2737243002 .
Cr-Commit-Position: refs/branch-heads/3029@{#74}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/93add423f47d3609dfeb2f1e49776d0d54ac69bb/gpu/config/gpu_driver_bug_list_json.cc

Cc: kainino@chromium.org
 Issue 701183  has been merged into this issue.
Components: -Internals>GPU>WebGL

Sign in to add a comment