New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698924 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Plumb recipe engine's recipes.py help text through tools/build's recipes.py help text

Project Member Reported by bpastene@chromium.org, Mar 7 2017

Issue description

It used to. But now running "recipes.py --help" in tools/build/scripts/slave doesn't give very helpful info (see below.) Not a big deal, but would be helpful.


$ python scripts/slave/recipes.py run --help
usage: recipes.py [-h] [-O PROJECT_OVERRIDE]

optional arguments:
  -h, --help            show this help message and exit
  -O PROJECT_OVERRIDE, --project-override PROJECT_OVERRIDE





$ python scripts/slave/.recipe_deps/recipe_engine/recipes.py run --help
usage: recipes.py run [-h] [--properties-file PROPERTIES_FILE]
                      [--properties PROPERTIES] [--workdir WORKDIR]
                      [--output-result-json OUTPUT_RESULT_JSON] [--timestamps]
                      recipe ...

Run a recipe locally

positional arguments:
  recipe                The recipe to execute
  props                 A list of property pairs; e.g.
                        mastername=chromium.linux issue= 12345 

optional arguments:
  -h, --help            show this help message and exit
  --properties-file PROPERTIES_FILE
                        A file containing a json blob of properties
  --properties PROPERTIES
                        A json string containing the properties
... etc etc ...
 
Status: Available (was: Untriaged)
Problem is https://cs.chromium.org/chromium/build/scripts/slave/recipes.py?q=recipes.py+package:%5Echromium$&dr=C&l=113

Specifically, we parse args here. If it sees the -h, it doesn't forward that to the file itself.

I think there's a fix for that?
Cc: phajdan.jr@chromium.org
Labels: -Pri-3 Pri-2
This is actually really annoying, so raising priority in case someone gets a chance to fix this.

Comment 3 by iannu...@google.com, Apr 11 2017

Status: Fixed (was: Available)
Fixed here: https://github.com/luci/recipes-py/commit/168be2068b30c07600603f1ce7fffe8f21348965

Sign in to add a comment