DevTools should not send X-Devtools-Emulate-Network-Conditions-Client-Id header
Reported by
anilka...@gmail.com,
Mar 7 2017
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: 1. Use DevTools API (json or ws endpoint) to load https://httpbin.org/get (which just emits the request headers) 2. Check the request headers for the presence of X-Devtools-Emulate-Network-Conditions-Client-Id What is the expected behavior? X-Devtools-Emulate-Network-Conditions-Client-Id header shouldn't be sent, and not be visible in the httpbin test above What went wrong? X-Devtools-Emulate-Network-Conditions-Client-Id header is sent, and it's visible in the httpbin test above Did this work before? N/A Chrome version: 57.0.2987.88 Channel: beta OS Version: Ubuntu 16.04.1 LTS Flash Version: Seems like this issue is related to past one: #395966
,
Mar 7 2017
This issue seems to be out of TE-scope. Hence, marking label TE-NeedsTriageHelp for further investigation. Thanks...!!
,
Mar 8 2017
Looking at https://bugs.chromium.org/p/chromium/issues/detail?id=395966#c27 it appears this is still an open issue. Is that right, dgozman, allada?
,
Mar 8 2017
Do you use Chrome or Content shell? I think Chrome should not do this. When I test manually in Chrome with DevTools open, I don't see the header in question.
,
Mar 8 2017
@dgozman: I tested it on Ubuntu Linux and Chrome with --headless argument or the headless_shell, via CDP ToT.
,
Mar 8 2017
Alex, could this be headless-specific? Do we run the code in DevToolsNetworkTransaction to remove the headers there?
,
Mar 9 2017
Looks like Headless isn't removing this header and it should. I'll get this fixed.
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43f04a7037dac960a00cb0c4ea7257369610921c commit 43f04a7037dac960a00cb0c4ea7257369610921c Author: alexclarke <alexclarke@chromium.org> Date: Mon Mar 13 21:20:10 2017 Headless: Strip X-DevTools-Emulate-Network-Conditions-Client-Id This header is added when the DevTools Network domain is active. It's supposed to be stripped before the fetch is sent down the wire. BUG= 546953 , 698905 Review-Url: https://codereview.chromium.org/2748743002 Cr-Commit-Position: refs/heads/master@{#456486} [modify] https://crrev.com/43f04a7037dac960a00cb0c4ea7257369610921c/headless/BUILD.gn [add] https://crrev.com/43f04a7037dac960a00cb0c4ea7257369610921c/headless/lib/browser/headless_network_delegate.cc [add] https://crrev.com/43f04a7037dac960a00cb0c4ea7257369610921c/headless/lib/browser/headless_network_delegate.h [modify] https://crrev.com/43f04a7037dac960a00cb0c4ea7257369610921c/headless/lib/browser/headless_url_request_context_getter.cc [modify] https://crrev.com/43f04a7037dac960a00cb0c4ea7257369610921c/headless/lib/headless_devtools_client_browsertest.cc [modify] https://crrev.com/43f04a7037dac960a00cb0c4ea7257369610921c/headless/test/test_protocol_handler.cc [modify] https://crrev.com/43f04a7037dac960a00cb0c4ea7257369610921c/headless/test/test_protocol_handler.h
,
Mar 14 2017
That should do it.
,
Mar 14 2017
Thanks guys! I'm guessing this has made it to the tip-of-tree, so I can probably use a dev/canary channel build to test it out?
,
Mar 15 2017
According to https://omahaproxy.appspot.com/ this made it into 59.0.3041.0 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nyerramilli@chromium.org
, Mar 7 2017