Make changes to Typ and GPU tests so that GPU tests can use test expectations files for test expectations |
|||||||||||||
Issue descriptionWe have some test with "Fail" expectation in https://cs.chromium.org/chromium/src/content/test/gpu/gpu_tests/webgl_conformance_expectations.py But, looking at JSON test results, these test have "actual": "PASS" and "expected": "PASS", instead of both being "FAIL". This is useful for detecting tests which were fixed, but for which the expectations were not updated.
,
Mar 7 2017
I think maybe I'm missing the bigger picture here. Why do you have tests that are expected to fail? Is there some way to rewrite them so that they aren't failing?
,
Mar 7 2017
One usage example is that a test might be passing on some platforms, but fail on others, where a feature is not implemented yet.
,
Mar 7 2017
Correct. The layout tests from which https://www.chromium.org/developers/the-json-test-results-format came had the possibility of expected failures, too. Is there a way to communicate this to typ so that we can more automatically discover tests which were previously failing and are now passing?
,
Mar 7 2017
There is no mechanism for having expected failures in typ at the moment. telemetry-based tests use unittests' mechanisms (more or less) to annotate individual test cases to skip tests if they are expected to not work and there's no point in running them, so that works fine for the "not on this platform yet" use case. layout tests would discover the tests, skip the ones it is expected to skip, run the rest, and process the results. However, in this case, we want to capture and display the actual results. It sounds like in this case we actually want to run the test but discard the results, and that's a bit more unusual, and actually kinda unrelated to whether a test passes or fails (though typ will not print the captured data for tests that pass by default).
,
Mar 17 2017
,
Apr 6 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 6 2018
this should still be marked available.
,
Jun 11 2018
I'm going to mark this as blocked on bug 835690 , which is where I'm adding support for test expectations to TYP itself. Once that's implemented, we can then use this bug to add the needed support to the gpu test frameworks.
,
Nov 8
Discussed offline, Rakib will take ownership of this bug
,
Nov 8
,
Jan 3
,
Jan 3
,
Jan 3
,
Jan 11
,
Jan 11
,
Jan 16
,
Jan 16
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by kbr@chromium.org
, Mar 7 2017Components: Internals>GPU>Testing Tests>Telemetry