New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698899 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Phishguard] Implement phishguard reporting functionality

Project Member Reported by jialiul@chromium.org, Mar 7 2017

Issue description

Implement Phishguard reporting functionality to send LoginReputationClientRequest and handle its response accordingly.

Requests are triggered by two types of events:
  (1) if the login page is not in the whitelist or cached
  (2) If user is reusing password.


 
#1 is top priority, though we want at least UMA data for #2.

We could gate the whole reporting flow on a Finch trial so we can enable/disable pings as needed.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fd4e054da246f044d62d18b626ff4afa68b7b72

commit 0fd4e054da246f044d62d18b626ff4afa68b7b72
Author: jialiul <jialiul@chromium.org>
Date: Tue Mar 07 20:59:17 2017

Copy LoginReputationClientRequest/Response protos

Copy LoginReputationClientRequest and LoginReputationClientResponse
protos from google3 to chrome/common/safe_browsing/csd.proto

BUG= 698899 

Review-Url: https://codereview.chromium.org/2733963003
Cr-Commit-Position: refs/heads/master@{#455215}

[modify] https://crrev.com/0fd4e054da246f044d62d18b626ff4afa68b7b72/chrome/common/safe_browsing/csd.proto

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3aafdc5ac1a6caf52c6c41615118e381ad9e549

commit f3aafdc5ac1a6caf52c6c41615118e381ad9e549
Author: jialiul <jialiul@chromium.org>
Date: Thu Mar 09 00:24:16 2017

Move chrome/common/safe_browsing/csd.proto to components/safe_browsing

Move csd.proto to components/safe_browsing.
This CL serves 2 purpose:
(1) moving csd.proto to component enables further componentization of
safe browsing reporting functionality, that will be used by WebView
(2) It also allows PasswordProtectionService, and PasswordManager code
to use these proto directly.

BUG= 698899 ,688629

Review-Url: https://codereview.chromium.org/2733343002
Cr-Commit-Position: refs/heads/master@{#455609}

[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/BUILD.gn
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/browser_feature_extractor.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/client_side_detection_service.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/client_side_model_loader.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/client_side_model_loader_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/download_feedback.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/download_feedback_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/download_protection_service.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/download_protection_service_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/environment_data_collection.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/extension_data_collection.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/incident.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/resource_request_incident.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/notification_image_reporter.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/notification_image_reporter_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/signature_evaluator_mac.mm
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/signature_evaluator_mac_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/threat_details.h
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/threat_details_cache.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/safe_browsing/threat_details_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/BUILD.gn
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/DEPS
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/safe_browsing/BUILD.gn
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/safe_browsing/binary_feature_extractor.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/safe_browsing/binary_feature_extractor_mac.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/safe_browsing/binary_feature_extractor_mac_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/safe_browsing/binary_feature_extractor_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/safe_browsing/binary_feature_extractor_win.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/safe_browsing/download_protection_util.h
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/safe_browsing/zip_analyzer.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/safe_browsing/zip_analyzer.h
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/common/safe_browsing/zip_analyzer_results.h
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/renderer/BUILD.gn
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/renderer/safe_browsing/DEPS
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/renderer/safe_browsing/phishing_classifier.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
[add] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/tools/safe_browsing/DEPS
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/tools/safe_browsing/sb_sigutil.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/utility/safe_browsing/mac/BUILD.gn
[add] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/utility/safe_browsing/mac/DEPS
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/chrome/utility/safe_browsing/mac/dmg_analyzer.cc
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/components/safe_browsing/BUILD.gn
[modify] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/components/safe_browsing/DEPS
[rename] https://crrev.com/f3aafdc5ac1a6caf52c6c41615118e381ad9e549/components/safe_browsing/csd.proto

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fdf43c8251e77df8fba1933f71b9a40b924359e

commit 7fdf43c8251e77df8fba1933f71b9a40b924359e
Author: jialiul <jialiul@chromium.org>
Date: Thu Mar 09 00:57:51 2017

Revert of Move chrome/common/safe_browsing/csd.proto to components/safe_browsing (patchset #2 id:20001 of https://codereview.chromium.org/2733343002/ )

Reason for revert:
revert this CL since it broke linux bots.

Original issue's description:
> Move chrome/common/safe_browsing/csd.proto to components/safe_browsing
>
> Move csd.proto to components/safe_browsing.
> This CL serves 2 purpose:
> (1) moving csd.proto to component enables further componentization of
> safe browsing reporting functionality, that will be used by WebView
> (2) It also allows PasswordProtectionService, and PasswordManager code
> to use these proto directly.
>
> BUG= 698899 ,688629
>
> Review-Url: https://codereview.chromium.org/2733343002
> Cr-Commit-Position: refs/heads/master@{#455609}
> Committed: https://chromium.googlesource.com/chromium/src/+/f3aafdc5ac1a6caf52c6c41615118e381ad9e549

TBR=nparker@chromium.org,vakh@chromium.org,sky@chromium.org,pkasting@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 698899 ,688629

Review-Url: https://codereview.chromium.org/2743483002
Cr-Commit-Position: refs/heads/master@{#455617}

[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/BUILD.gn
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/browser_feature_extractor.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/client_side_detection_service.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/client_side_model_loader.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/client_side_model_loader_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/download_feedback.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/download_feedback_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/download_protection_service.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/download_protection_service_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/environment_data_collection.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/extension_data_collection.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/incident.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/resource_request_incident.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/notification_image_reporter.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/notification_image_reporter_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/signature_evaluator_mac.mm
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/signature_evaluator_mac_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/threat_details.h
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/threat_details_cache.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/safe_browsing/threat_details_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/BUILD.gn
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/DEPS
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/safe_browsing/BUILD.gn
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/safe_browsing/binary_feature_extractor.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/safe_browsing/binary_feature_extractor_mac.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/safe_browsing/binary_feature_extractor_mac_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/safe_browsing/binary_feature_extractor_unittest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/safe_browsing/binary_feature_extractor_win.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc
[rename] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/safe_browsing/csd.proto
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/safe_browsing/download_protection_util.h
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/safe_browsing/zip_analyzer.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/safe_browsing/zip_analyzer.h
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/common/safe_browsing/zip_analyzer_results.h
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/renderer/BUILD.gn
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/renderer/safe_browsing/DEPS
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/renderer/safe_browsing/phishing_classifier.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
[delete] https://crrev.com/7801ddb228446b02c1a806826c66c5f0d15326d2/chrome/tools/safe_browsing/DEPS
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/tools/safe_browsing/sb_sigutil.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/utility/safe_browsing/mac/BUILD.gn
[delete] https://crrev.com/7801ddb228446b02c1a806826c66c5f0d15326d2/chrome/utility/safe_browsing/mac/DEPS
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/chrome/utility/safe_browsing/mac/dmg_analyzer.cc
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/components/safe_browsing/BUILD.gn
[modify] https://crrev.com/7fdf43c8251e77df8fba1933f71b9a40b924359e/components/safe_browsing/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64fc03ab5fd993cc6573fa24266d177aaf8b1679

commit 64fc03ab5fd993cc6573fa24266d177aaf8b1679
Author: jialiul <jialiul@chromium.org>
Date: Tue Mar 21 21:49:50 2017

PasswordProtectionService verdict cache management

Add functionalities to PasswordProtectionService to:
(1) cache pps verdict based on origin and cache expression in
HostContentSettingsMap
(2) Get cached verdict from HostContentSettingsMap
(3) Remove cached verdict upon URLs deleted from history service.

BUG= 698899 

Review-Url: https://codereview.chromium.org/2747313002
Cr-Commit-Position: refs/heads/master@{#458565}

[modify] https://crrev.com/64fc03ab5fd993cc6573fa24266d177aaf8b1679/components/content_settings/core/browser/website_settings_registry.cc
[modify] https://crrev.com/64fc03ab5fd993cc6573fa24266d177aaf8b1679/components/content_settings/core/common/content_settings_types.h
[modify] https://crrev.com/64fc03ab5fd993cc6573fa24266d177aaf8b1679/components/safe_browsing/csd.proto
[modify] https://crrev.com/64fc03ab5fd993cc6573fa24266d177aaf8b1679/components/safe_browsing/password_protection/BUILD.gn
[modify] https://crrev.com/64fc03ab5fd993cc6573fa24266d177aaf8b1679/components/safe_browsing/password_protection/DEPS
[modify] https://crrev.com/64fc03ab5fd993cc6573fa24266d177aaf8b1679/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/64fc03ab5fd993cc6573fa24266d177aaf8b1679/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/64fc03ab5fd993cc6573fa24266d177aaf8b1679/components/safe_browsing/password_protection/password_protection_service_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ac305b92081fe7f56daa698d738a040317d9785

commit 1ac305b92081fe7f56daa698d738a040317d9785
Author: jialiul <jialiul@chromium.org>
Date: Sat Mar 25 00:59:07 2017

Create PasswordProtectionRequest to handle password pings

PasswordProtectionRequest will check the following conditions to
determin if a ping will be sent out:
(1) only send ping with SBER user (for now)
(2) only send ping if not in incognito mode (for now)
(3) only send ping for non-whitelisted URL
(4) only send ping if no cached verdict available

BUG= 698899 

Review-Url: https://codereview.chromium.org/2773483003
Cr-Commit-Position: refs/heads/master@{#459611}

[modify] https://crrev.com/1ac305b92081fe7f56daa698d738a040317d9785/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/1ac305b92081fe7f56daa698d738a040317d9785/components/safe_browsing/password_protection/BUILD.gn
[modify] https://crrev.com/1ac305b92081fe7f56daa698d738a040317d9785/components/safe_browsing/password_protection/DEPS
[add] https://crrev.com/1ac305b92081fe7f56daa698d738a040317d9785/components/safe_browsing/password_protection/password_protection_request.cc
[add] https://crrev.com/1ac305b92081fe7f56daa698d738a040317d9785/components/safe_browsing/password_protection/password_protection_request.h
[modify] https://crrev.com/1ac305b92081fe7f56daa698d738a040317d9785/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/1ac305b92081fe7f56daa698d738a040317d9785/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/1ac305b92081fe7f56daa698d738a040317d9785/components/safe_browsing/password_protection/password_protection_service_unittest.cc
[modify] https://crrev.com/1ac305b92081fe7f56daa698d738a040317d9785/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4522d139cf6832a2f3393d374dd9b025902935dc

commit 4522d139cf6832a2f3393d374dd9b025902935dc
Author: jialiul <jialiul@chromium.org>
Date: Wed Apr 05 21:56:06 2017

Link PasswordProtectionService to Profile and SB Service

1. Refactor PasswordProtectionService to be a per Profile class.
2. Create ChromePasswordProtectionService subclass in c/b/safe_browsing/ to
to link Profile instances to password protection.
3. Make SafeBrowsingService observe the creation and destruction of profiles,
and create/remove ChromePasswordProtection instances accordingly.

BUG= 698899 

Review-Url: https://codereview.chromium.org/2783773002
Cr-Commit-Position: refs/heads/master@{#462233}

[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/chrome/browser/BUILD.gn
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/chrome/browser/password_manager/chrome_password_manager_client.h
[add] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/chrome/browser/safe_browsing/chrome_password_protection_service.cc
[add] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/chrome/browser/safe_browsing/chrome_password_protection_service.h
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/components/password_manager/core/browser/password_reuse_detection_manager.cc
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/components/password_manager/core/browser/password_reuse_detection_manager.h
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/components/password_manager/core/browser/stub_password_manager_client.cc
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/components/password_manager/core/browser/stub_password_manager_client.h
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/components/safe_browsing/password_protection/BUILD.gn
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/components/safe_browsing/password_protection/password_protection_request.cc
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/components/safe_browsing/password_protection/password_protection_request.h
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/components/safe_browsing/password_protection/password_protection_service_unittest.cc
[modify] https://crrev.com/4522d139cf6832a2f3393d374dd9b025902935dc/tools/metrics/histograms/histograms.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb38d9eecf60aced7882a7f962eecd743efd2a91

commit eb38d9eecf60aced7882a7f962eecd743efd2a91
Author: jialiul <jialiul@chromium.org>
Date: Thu Apr 13 01:02:06 2017

Deprecate cache_expression_exact_match

Deprecate cache_expression_exact_match proto field in
LoginRepurationResponse, and remove its related matching
logic and tests.

After looking closer at the site_chunk rules, using a
simple boolean cache_expression_exact_match field is
not enough for some corner cases. Therefore, we
proposed to make the backend compute the most
appropriate cache_expression for all the corner cases
(instead of handling complex logic in client.)
go/cache_expression_matching

BUG= 698899 

Review-Url: https://codereview.chromium.org/2813063003
Cr-Commit-Position: refs/heads/master@{#464225}

[modify] https://crrev.com/eb38d9eecf60aced7882a7f962eecd743efd2a91/components/safe_browsing/csd.proto
[modify] https://crrev.com/eb38d9eecf60aced7882a7f962eecd743efd2a91/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/eb38d9eecf60aced7882a7f962eecd743efd2a91/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/eb38d9eecf60aced7882a7f962eecd743efd2a91/components/safe_browsing/password_protection/password_protection_service_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cffb12884df959d94c1e3bb67e9d8bcae2c339a

commit 3cffb12884df959d94c1e3bb67e9d8bcae2c339a
Author: jialiul <jialiul@chromium.org>
Date: Wed Apr 19 19:12:43 2017

Improve PasswordProtectionService and PasswordProtectionRequest

(1) refactor PaswordProtectionRequest to be RefCountedThreadSafe,
(2) use CancelableTaskTracker in PasswordProtectionRequest to make
    sure tasks posted on IO thread can be canceled correctly upon
    destructing PasswordProtectionService,
(3) Add the skeleton of PasswordProtectionFrame struct, which will be
    used to communicate password form information between
    ChromePasswordManagerClient and PasswordProtectionService

BUG= 698899 

Review-Url: https://codereview.chromium.org/2817533004
Cr-Commit-Position: refs/heads/master@{#465695}

[modify] https://crrev.com/3cffb12884df959d94c1e3bb67e9d8bcae2c339a/chrome/browser/safe_browsing/chrome_password_protection_service.h
[modify] https://crrev.com/3cffb12884df959d94c1e3bb67e9d8bcae2c339a/components/safe_browsing/password_protection/password_protection_request.cc
[modify] https://crrev.com/3cffb12884df959d94c1e3bb67e9d8bcae2c339a/components/safe_browsing/password_protection/password_protection_request.h
[modify] https://crrev.com/3cffb12884df959d94c1e3bb67e9d8bcae2c339a/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/3cffb12884df959d94c1e3bb67e9d8bcae2c339a/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/3cffb12884df959d94c1e3bb67e9d8bcae2c339a/components/safe_browsing/password_protection/password_protection_service_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a0fcb3039c48ad810531e785637cbb9fe59d6c7

commit 1a0fcb3039c48ad810531e785637cbb9fe59d6c7
Author: jialiul <jialiul@chromium.org>
Date: Tue May 02 18:46:18 2017

Trigger Password Protection ping on username/password field on focus.

Add CheckSafeBrowsingReputation() function to autofill_driver.mojom.
ContentPasswordDriver overrides this function to kick in
PasswordProtectionService.

BUG= 698899 

Review-Url: https://codereview.chromium.org/2833193002
Cr-Commit-Position: refs/heads/master@{#468716}

[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/chrome/renderer/autofill/fake_content_password_manager_driver.cc
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/chrome/renderer/autofill/fake_content_password_manager_driver.h
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/autofill/content/common/BUILD.gn
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/autofill/content/common/autofill_driver.mojom
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/autofill/content/renderer/password_autofill_agent.h
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/password_manager/content/browser/content_password_manager_driver.cc
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/password_manager/content/browser/content_password_manager_driver.h
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/password_manager/content/browser/content_password_manager_driver_unittest.cc
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/password_manager/core/browser/stub_password_manager_client.cc
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/password_manager/core/browser/stub_password_manager_client.h
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/safe_browsing/password_protection/password_protection_request.cc
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/safe_browsing/password_protection/password_protection_request.h
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/1a0fcb3039c48ad810531e785637cbb9fe59d6c7/components/safe_browsing/password_protection/password_protection_service_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b

commit fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b
Author: jialiul <jialiul@chromium.org>
Date: Tue May 09 04:36:53 2017

Add Finch feature and parameters to control user population for low reputation requests and password reuse requests.

There are 3 experiment populations that corresponds to our launch plan:
(1) SBER && !incognito
(2) (SBER || Sync) && !incognito
(3) everyone

BUG= 698899 

Review-Url: https://codereview.chromium.org/2856033002
Cr-Commit-Position: refs/heads/master@{#470212}

[modify] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/chrome/browser/safe_browsing/chrome_password_protection_service.cc
[modify] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/chrome/browser/safe_browsing/chrome_password_protection_service.h
[add] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
[modify] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/chrome/test/BUILD.gn
[modify] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/components/safe_browsing/csd.proto
[modify] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/components/safe_browsing/password_protection/password_protection_request.cc
[modify] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/components/safe_browsing/password_protection/password_protection_request.h
[modify] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/components/safe_browsing/password_protection/password_protection_service_unittest.cc
[modify] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/fe7f0c917485514e7ce80aac4ea56d4d4ffbb41b/tools/metrics/histograms/enums.xml

Project Member

Comment 13 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31a45cd7736a6224fa8f7b6eafc091fd25d8b803

commit 31a45cd7736a6224fa8f7b6eafc091fd25d8b803
Author: jialiul <jialiul@chromium.org>
Date: Thu May 18 16:04:56 2017

Trigger protected password entry request on password reuse event.

BUG= 698899 

Review-Url: https://codereview.chromium.org/2878813002
Cr-Commit-Position: refs/heads/master@{#472828}

[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/components/password_manager/core/browser/password_reuse_detection_manager.cc
[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/components/password_manager/core/browser/stub_password_manager_client.cc
[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/components/password_manager/core/browser/stub_password_manager_client.h
[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/components/safe_browsing/password_protection/password_protection_request.cc
[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/components/safe_browsing/password_protection/password_protection_request.h
[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/components/safe_browsing/password_protection/password_protection_service_unittest.cc
[modify] https://crrev.com/31a45cd7736a6224fa8f7b6eafc091fd25d8b803/tools/metrics/histograms/histograms.xml

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cd85bfda2021baba6a044d565323ab88e598398

commit 4cd85bfda2021baba6a044d565323ab88e598398
Author: jialiul <jialiul@chromium.org>
Date: Thu Jun 08 00:09:44 2017

Fill is_chrome_signin_password field in the password entry pings.

For all the password reuse triggered by CheckSyncPasswordReuse(..),
set the saved_domain to password_manager::kSyncPasswordDomain to
distinguish from saved password reuse.
Related BUILD files are adjusted. And this CL also moves the creation
and removal of PasswordProtectionService instances to SB service delegate.

BUG= 698899 

Review-Url: https://codereview.chromium.org/2912383004
Cr-Commit-Position: refs/heads/master@{#477816}

[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/chrome/browser/BUILD.gn
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/chrome/browser/safe_browsing/services_delegate.h
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/chrome/browser/safe_browsing/services_delegate_impl.cc
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/chrome/browser/safe_browsing/services_delegate_impl.h
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/chrome/browser/safe_browsing/services_delegate_stub.cc
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/chrome/browser/safe_browsing/services_delegate_stub.h
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/components/password_manager/core/browser/password_reuse_detection_manager.cc
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/components/password_manager/core/browser/password_reuse_detector.cc
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/components/password_manager/core/browser/password_reuse_detector.h
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/components/password_manager/core/browser/password_reuse_detector_consumer.h
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/components/password_manager/core/browser/password_reuse_detector_unittest.cc
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/components/password_manager/core/browser/password_store_unittest.cc
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/components/safe_browsing/password_protection/BUILD.gn
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/components/safe_browsing/password_protection/DEPS
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/components/safe_browsing/password_protection/password_protection_request.cc
[modify] https://crrev.com/4cd85bfda2021baba6a044d565323ab88e598398/components/safe_browsing/password_protection/password_protection_service_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment