New issue
Advanced search Search tips

Issue 698894 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 693114



Sign in to add a comment

Couple of WindowCycleControllerTests fail in mash

Project Member Reported by sky@chromium.org, Mar 6 2017

Issue description

At least one fails because of lack of display_manager.
 

Comment 1 by sky@chromium.org, Mar 7 2017

Blocking: 693114
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea37af717f1569dd93282e09b6fb49ff22b771f8

commit ea37af717f1569dd93282e09b6fb49ff22b771f8
Author: sky <sky@chromium.org>
Date: Tue Mar 07 22:59:41 2017

Last sets of tests that can move to common_unittests

This way they run in both mash_unittests and ash_unittests.
Interesting things of note:
. Had to remove DCHECKs for GetRootWindowForDisplayId() as some tests
  call with invalid.
. Had to rename class in mus named WindowManagerTest as it conflicts
  with test with same name in ash.

BUG= 622486 , 631103 , 637853 , 648733 ,695556, 696028 ,698091, 698129 , 698878 , 698887 ,698888,698892,698894, 698895 , 698914 ,699172,699175, 693114 
TEST=test changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2739703003
Cr-Commit-Position: refs/heads/master@{#455272}

[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/BUILD.gn
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/mus/window_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/test/ash_test_base.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_modality_controller_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_util_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/workspace/workspace_window_resizer_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8675cbb337440a11bf9afb10ea11bae42bb92cb

commit f8675cbb337440a11bf9afb10ea11bae42bb92cb
Author: James Cook <jamescook@chromium.org>
Date: Fri Nov 03 17:59:35 2017

cros: Enable some tests in //ash/wm in ash_unittests --mash

For the ones that fail, disable them via filter file instead of in the
code, per our disablement policy.

Bug: 698085, 695556,  698878 , 698888, 698093, 698894
Test: ash_unittests --mash
Change-Id: Ic145ab6a95508968d6884d14fac2a3ca08888d26
Reviewed-on: https://chromium-review.googlesource.com/752423
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513836}
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/testing/buildbot/filters/ash_unittests_mash.filter

Components: Tests>Disabled
Labels: Test-Disabled
Components: Internals>Services>Ash
Labels: -Proj-Mustash-Mash

Sign in to add a comment