New issue
Advanced search Search tips

Issue 698890 link

Starred by 1 user
Status: Fixed
Owner:
xiaoche...@chromium.org
Closed: Mar 2017
Cc:
editing-dev@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 517298



Sign in to add a comment

Reorganize layout tests in editing/spelling

Project Member Reported by xiaoche...@chromium.org, Mar 6 2017 
Not all layout tests in editing/spelling verify spell checker. The following tests verify marker appearance instead:

1. grammar-markers[-hidpi].html

2. inline-spelling-markers[-hidpi[-composited]].html

They should be moved to paint/spellmarkers

Comment 1 by xiaoche...@chromium.org, Mar 6 2017

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a

commit a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Mar 07 14:51:40 2017

Move tests in editing/spelling for marker appearance to paint/spellmarkers

The follow tests verify appearance of spelling/grammar markers, but do not
verify Blink's spell checker:
- editing/spelling/inline_spelling_markers.html
- editing/spelling/inline-spelling-markers-hidpi.html
- editing/spelling/inline-spelling-markers-hidpi-composited.html
- editing/spelling/grammar-markers.html
- editing/spelling/grammar-markers-hidpi.html

Hence, this patch moves them to paint/spellmarkers.

BUG= 698890 

Review-Url: https://codereview.chromium.org/2736823002
Cr-Commit-Position: refs/heads/master@{#455071}

[modify] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/paint/spellmarkers/grammar-markers-hidpi.html
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/paint/spellmarkers/grammar-markers.html
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/paint/spellmarkers/inline-spelling-markers-hidpi-composited.html
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/paint/spellmarkers/inline-spelling-markers-hidpi.html
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/paint/spellmarkers/inline_spelling_markers.html
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/grammar-markers-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/grammar-markers-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/grammar-markers-hidpi-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/grammar-markers-hidpi-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline-spelling-markers-hidpi-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline-spelling-markers-hidpi-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline_spelling_markers-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/linux/paint/spellmarkers/inline_spelling_markers-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/grammar-markers-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/grammar-markers-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/grammar-markers-hidpi-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/grammar-markers-hidpi-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline-spelling-markers-hidpi-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline-spelling-markers-hidpi-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline_spelling_markers-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/mac/paint/spellmarkers/inline_spelling_markers-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/grammar-markers-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/grammar-markers-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/grammar-markers-hidpi-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/grammar-markers-hidpi-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline-spelling-markers-hidpi-composited-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline-spelling-markers-hidpi-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline-spelling-markers-hidpi-expected.txt
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline_spelling_markers-expected.png
[rename] https://crrev.com/a79e6ad57d1f1e019d62e9d0e990dbdd25177a0a/third_party/WebKit/LayoutTests/platform/win/paint/spellmarkers/inline_spelling_markers-expected.txt

Comment 3 by schenney@chromium.org, Mar 7 2017

Labels: PaintTeamTriaged-20170607 BugSource-Chromium

Comment 4 by schenney@chromium.org, Mar 7 2017

Labels: -PaintTeamTriaged-20170607 PaintTeamTriaged-20170307

Comment 5 by xiaoche...@chromium.org, Mar 7 2017

Labels: M-59
Status: Fixed (was: Assigned)
►

Sign in to add a comment