New issue
Advanced search Search tips

Issue 698883 link

Starred by 1 user
Status: Fixed
Owner:
xiaoche...@chromium.org
Closed: Mar 2017
Cc:
editing-dev@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 517298



Sign in to add a comment

Layout tests in paint/spellmarkers should not depend on Blink's spell checker

Project Member Reported by xiaoche...@chromium.org, Mar 6 2017 
Layout tests in paint/spellmarkers rely on Blink's spell checker to add markers, and then verify the appearance of the markers.

They should utilize internals.setMarker to add markers directly, so that they won't fail if Blink's spell checker is re-architectured.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e58d543442b2f3049b0bd22f2a537c05cbed6a2a

commit e58d543442b2f3049b0bd22f2a537c05cbed6a2a
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Mar 07 14:54:31 2017

Use internals.setMarker in layout tests in paint/spellmarkers/

This patch removes the dependency of layout tests in paint/spellmarkers/
on the implementation of Blink's spell checker, by making them add markers
directly with internals.setMarker().

As a result, they are no longer affected by spell checker rearchitecturing
(e.g., idle time spell checker).

BUG= 698883 

Review-Url: https://codereview.chromium.org/2737643002
Cr-Commit-Position: refs/heads/master@{#455073}

[modify] https://crrev.com/e58d543442b2f3049b0bd22f2a537c05cbed6a2a/third_party/WebKit/LayoutTests/paint/spellmarkers/document-markers-zoom-125.html
[modify] https://crrev.com/e58d543442b2f3049b0bd22f2a537c05cbed6a2a/third_party/WebKit/LayoutTests/paint/spellmarkers/document-markers-zoom-150.html
[modify] https://crrev.com/e58d543442b2f3049b0bd22f2a537c05cbed6a2a/third_party/WebKit/LayoutTests/paint/spellmarkers/document-markers-zoom-175.html
[modify] https://crrev.com/e58d543442b2f3049b0bd22f2a537c05cbed6a2a/third_party/WebKit/LayoutTests/paint/spellmarkers/document-markers-zoom-200.html
[modify] https://crrev.com/e58d543442b2f3049b0bd22f2a537c05cbed6a2a/third_party/WebKit/LayoutTests/paint/spellmarkers/document-markers-zoom-250.html
[modify] https://crrev.com/e58d543442b2f3049b0bd22f2a537c05cbed6a2a/third_party/WebKit/LayoutTests/paint/spellmarkers/document-markers.html

Comment 2 by schenney@chromium.org, Mar 7 2017

Labels: BugSource-Chromium PaintTeamTriaged-20170307

Comment 3 by xiaoche...@chromium.org, Mar 7 2017

Labels: M-59
Status: Fixed (was: Assigned)
►

Sign in to add a comment