New issue
Advanced search Search tips

Issue 698866 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocking:
issue 684099



Sign in to add a comment

Remove C-style calls in accounts_collection_egtest

Project Member Reported by baxley@chromium.org, Mar 6 2017 
There are a lot of C-style calls wrapping Objective C calls, where a helper matcher should be used to make the test more consistent with EarlGrey.

For example, TapButtonWithLabelID
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/888c1d23cef857d6b6f784f5499092485669e3c9

commit 888c1d23cef857d6b6f784f5499092485669e3c9
Author: Mike Baxley <baxley@chromium.org>
Date: Fri May 12 20:56:45 2017

Fix AccountCollectionsTestCase to be more EarlGrey-like.

Fix bugs in how menus are tapped when elements are not visible,
and create shared matchers and utilities to tap menus. Also create
shared matchers for sign in buttons.

Bug:  698866 , 717163 
Change-Id: I7ccdfbb39d359a7a3461a670961e720ed4706fd3
Reviewed-on: https://chromium-review.googlesource.com/505209
Commit-Queue: Mike Baxley <baxley@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471441}
[modify] https://crrev.com/888c1d23cef857d6b6f784f5499092485669e3c9/ios/chrome/browser/ui/settings/accounts_collection_egtest.mm
[modify] https://crrev.com/888c1d23cef857d6b6f784f5499092485669e3c9/ios/chrome/test/earl_grey/chrome_earl_grey_ui.h
[modify] https://crrev.com/888c1d23cef857d6b6f784f5499092485669e3c9/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
[modify] https://crrev.com/888c1d23cef857d6b6f784f5499092485669e3c9/ios/chrome/test/earl_grey/chrome_matchers.h
[modify] https://crrev.com/888c1d23cef857d6b6f784f5499092485669e3c9/ios/chrome/test/earl_grey/chrome_matchers.mm

Comment 2 by eugene...@chromium.org, Sep 14 2017

Labels: -Type-Bug -Pri-2 Pri-3 Type-Task
Should we close this now? accounts_collection_egtest has only 2 C-methods (AcceptAccountConsistencyPopup and ButtonWithIdentity) and these methods look reasonable.

Comment 3 by baxley@chromium.org, Sep 14 2017

Status: Fixed (was: Available)
►

Sign in to add a comment