Issue metadata
Sign in to add a comment
|
<video>.captureStream() changes the colours of the original <video> when being played back |
||||||||||||||||||||||||
Issue descriptionSee demo https://webrtc.github.io/samples/src/content/capture/video-video/, in Mac, the colours of the original video seem to have the chrome channels swapped? Observed only on Mac Canary. See attached file.
,
Mar 7 2017
Adding some peeps. dcastagna@ do you know if we're (re)using some resource in WebMediaPlayerMS [1] that corrupts a "normal" WebMediaPlayerMS (or its internal SkCanvasVideoRenderer...) ? [1] https://cs.chromium.org/chromium/src/content/renderer/media/webmediaplayer_ms.h?q=WebMediaPlayer_MS&dr=CSs
,
Mar 7 2017
,
Mar 7 2017
Is this a regression? Is this happening only on Mac? We save a cache of the last converted VideoFrame in SkCanvasVideoRenderer::last_image_, do you think it could be related to this issue? ccameron@ has been working on video color conversion on Mac lately, any chance this could be related to crbug.com/676054 ?
,
Mar 7 2017
1) this is a regression: although this feature is not shipped, it was announced and the demo worked back then (~EOQ216). It's positively only happening on Mac, at least as far as I have tested, Linux and Win are OK. +ccameron@ for more inputs
,
Mar 7 2017
Can you quickly check with --disable-features=video-color-management (and --enable-features as well)?
,
Mar 7 2017
I'm running ./out/gn/Chromium.app/Contents/MacOS/Chromium \ -vmodule="*html_*_element_capturer*=2,*HTMLMediaElementCapture*=1,*video_track_recorder*=3" \ --enable-blink-features=MediaCaptureFromVideo \ https://codepen.io/miguelao/full/OpXVVK --disable-features=video-color-management but still the original <video> goes bananas colour-wise.
,
Mar 7 2017
Can you bisect if it's a regression?
,
Mar 7 2017
I'm also taking a look as soon as my local build completes...
,
Mar 7 2017
I have a local repro too.
,
Mar 7 2017
Bisect isn't running any recent builds, complaining that dlopen /private/var/folders/00/191h0000h01000cxqpysvccm005460/T/bisect_tmpSXkMIn/chrome-mac/Chromium.app/Contents/MacOS/../Versions/58.0.3027.0/Chromium Framework.framework/Chromium Framework: dlopen(/private/var/folders/00/191h0000h01000cxqpysvccm005460/T/bisect_tmpSXkMIn/chrome-mac/Chromium.app/Contents/MacOS/../Versions/58.0.3027.0/Chromium Framework.framework/Chromium Framework, 261): no suitable image found. Did find: /private/var/folders/00/191h0000h01000cxqpysvccm005460/T/bisect_tmpSXkMIn/chrome-mac/Chromium.app/Contents/MacOS/../Versions/58.0.3027.0/Chromium Framework.framework/Chromium Framework: file too short
,
Mar 7 2017
Is anyone having luck bisecting this?
,
Mar 7 2017
,
Mar 7 2017
Just tried r455269 which includes the fix in https://bugs.chromium.org/p/chromium/issues/detail?id=699123#c7 and I cannot repro, all looks normal, thanks ccameron@ ! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mcasas@chromium.org
, Mar 7 2017