New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698859 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Improve robustness of network_WiFi_DisconnectReason

Project Member Reported by briannorris@chromium.org, Mar 6 2017

Issue description

This test has a number of shortcomings.

#### 1 ####

Quoting the control files:

"This test reads (but does not verify) the reported DiconnectReason property
reported by supplicant when [...]"

Given that we've made some efforts to get various drivers to correctly report their disconnection reason, it seems prudent to have our tests verify that they are reported correctly, at least for the few error cases we check for in these tests.


#### 2 ####

The code for grabbing disconnection reasons (server/cros/network/wifi_client.py get_disconnect_reasons()) just does a blind regex on net.log, which can include multiple disconnection reasons, including from previous runs. This can cause false positives today (we're just checking that there was *some* disconnection in the past), and it will definitely mess with fixing up #1 above.

We should probably make this check smarter, to only retrieve disconnections since the start of the test.

---

I might take a stab at this sometime, but it's certainly not high on my priority plate. So please steal from me if you'd like.
 
Cc: harpreet@chromium.org
Labels: -Pri-3 Pri-2
Owner: debayanb@chromium.org
Test team is currently going through all the flaky/failing WiFi tests and determining the cause for failures and fixing tests / setup as needed.

Here is a list of such tests: https://docs.google.com/spreadsheets/d/1oazhz3TZxP0-YdgfkHCdQ6e2WEm9cOEkwoJ92c057LQ/edit#gid=995330945


Assigning this to debayanb@. He'll reach out to you if he has any questions about your suggestions on fixing this test.

I don't have access to that doc. (Requested.)

I didn't particularly notice flakiness in practice; I was just reviewing the test, as I was planning to use it.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 7 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: akhouderchah@chromium.org
Status: Started (was: Untriaged)
Labels: -Hotlist-Recharge-Cold

Sign in to add a comment