Improve robustness of network_WiFi_DisconnectReason |
||||
Issue descriptionThis test has a number of shortcomings. #### 1 #### Quoting the control files: "This test reads (but does not verify) the reported DiconnectReason property reported by supplicant when [...]" Given that we've made some efforts to get various drivers to correctly report their disconnection reason, it seems prudent to have our tests verify that they are reported correctly, at least for the few error cases we check for in these tests. #### 2 #### The code for grabbing disconnection reasons (server/cros/network/wifi_client.py get_disconnect_reasons()) just does a blind regex on net.log, which can include multiple disconnection reasons, including from previous runs. This can cause false positives today (we're just checking that there was *some* disconnection in the past), and it will definitely mess with fixing up #1 above. We should probably make this check smarter, to only retrieve disconnections since the start of the test. --- I might take a stab at this sometime, but it's certainly not high on my priority plate. So please steal from me if you'd like.
,
Mar 7 2017
I don't have access to that doc. (Requested.) I didn't particularly notice flakiness in practice; I was just reviewing the test, as I was planning to use it.
,
Mar 7 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 5
,
Jul 5
|
||||
►
Sign in to add a comment |
||||
Comment 1 by harpreet@chromium.org
, Mar 7 2017Labels: -Pri-3 Pri-2
Owner: debayanb@chromium.org