New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698857 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 19 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: ----



Sign in to add a comment

Remove Popular sites experiment on iOS

Project Member Reported by noyau@chromium.org, Mar 6 2017

Issue description

Turns Popular Sites on for 100% of the population.
 

Comment 1 by noyau@chromium.org, Mar 6 2017

Components: UI>Browser>NewTabPage
Owner: noyau@chromium.org

Comment 2 by noyau@chromium.org, Mar 6 2017

Labels: ReleaseBlock-Stable M-58

Comment 4 by noyau@chromium.org, Mar 13 2017

Labels: Merge-Request-58

Comment 5 by noyau@chromium.org, Mar 13 2017

Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 13 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 14 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30e9e0e564bbfb04e7096e7dd4b701f22d20785c

commit 30e9e0e564bbfb04e7096e7dd4b701f22d20785c
Author: Eric Noyau <noyau@google.com>
Date: Tue Mar 14 20:07:13 2017

Remove Popular Sites experiment on iOS.

Switch all population to Popular sites.

BUG= 698857 

Review-Url: https://codereview.chromium.org/2737573003
Cr-Commit-Position: refs/heads/master@{#455176}
(cherry picked from commit f4ac7d77d34333b0873a799dc17097818b82d589)

Review-Url: https://codereview.chromium.org/2754523002 .
Cr-Commit-Position: refs/branch-heads/3029@{#193}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/30e9e0e564bbfb04e7096e7dd4b701f22d20785c/components/ntp_tiles/field_trial.cc
[modify] https://crrev.com/30e9e0e564bbfb04e7096e7dd4b701f22d20785c/components/ntp_tiles/field_trial.h
[modify] https://crrev.com/30e9e0e564bbfb04e7096e7dd4b701f22d20785c/ios/chrome/browser/ios_chrome_field_trials.cc

Status: Verified (was: Fixed)
Tested in the M58.0.3029.83 dev, the popular sites are displaying by default on launch.

Sign in to add a comment