New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698855 link

Starred by 5 users

Issue metadata

Status: Fixed
Merged: issue 720030
Owner:
Closed: Oct 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 720030



Sign in to add a comment

File Manager displaying date in YYYY "M"MM D format

Reported by kaingard...@gmail.com, Mar 6 2017

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 9331.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3027.0 Safari/537.36
Platform: 9331.0.0 (Official Build) dev-channel swanky

Steps to reproduce the problem:
1. Open File Manager
2. Observe file date format 
3. Todays date (7 March 2017) is listed as 2017 M02 7

What is the expected behavior?
Date should match system format for date - depending on locale. In Australia this is 07/2/2017 or 07 02 2017 

What went wrong?
Dates are formatted in non intuitive fashion

Did this work before? N/A 

Chrome version: 58.0.3027.0  Channel: dev
OS Version: 9331.0.0
Flash Version: 24.0.0.221 /opt/google/chrome/pepper/libpepflashplayer.so

 
Screenshot 2017-03-07 at 8.25.37 AM.png
402 KB View Download
Components: Platform>Apps>FileManager
Cc: abod...@chromium.org rookrishna@chromium.org dhadd...@chromium.org sdantul...@chromium.org
Cc: yoshi@chromium.org fukino@chromium.org
 Issue 719164  has been merged into this issue.
Components: UI>Localization
Status: Untriaged (was: Unconfirmed)

Comment 6 by fukino@chromium.org, May 12 2017

Owner: yamaguchi@chromium.org
Status: Assigned (was: Untriaged)
yamaguchi@, could you handle this?
This is broken sometime in M58.
I checked English (United Kingdom) and English (Australia) on ToT, but the issue did not reproduced.
Reproduced on 60.0.3088.0 (developer build) on Chromebook Pixel, with language = English (Australia).

Comment 8 by yoshi@chromium.org, May 12 2017

Cc: -yoshi@chromium.org
Labels: -Pri-2 Pri-1
Setting Pri to 1 as we think this is likely to be affecting more than the Files app and Chrome OS.
Status: Started (was: Assigned)
http://jsfiddle.net/mmfcL58z/2/
I could reproduce it in Chrome browser but only on the same machine as #7.
It's likely to be caused when passing an empty list parameter passed Intl.DateTimeFormat constructor.
Changing 'locales' to ['en-AU'] gives a result like "12 May 2017, 3:45 pm".
Components: -UI>Localization -Platform>Apps>FileManager Blink>JavaScript>API
Labels: -Pri-1 Pri-2
Status: Untriaged (was: Started)
Changing components because this is not specific issue on the Files app on Chrome OS as described in #10.
Setting to Pri-2 for triage.
Cc: -rookrishna@chromium.org jochen@chromium.org yangguo@chromium.org yamaguchi@chromium.org
Owner: littledan@chromium.org
Status: Assigned (was: Untriaged)
Hi Dan, can you have a look? You touched ICU date recently. Maybe something broke there?
 Issue 722821  has been merged into this issue.
Mergedinto: 714301
Status: Duplicate (was: Assigned)
Status: (was: Duplicate)
Status: Untriaged
I don't think this is related to 714301, because this issue is not about the timezone specification on the construction of a Date object, but about the i18n formatting of Date object.
Owner: adamk@chromium.org
Status: Assigned (was: Untriaged)

Comment 18 by adamk@chromium.org, May 23 2017

Cc: littledan@chromium.org
Components: -Blink>JavaScript>API Blink>JavaScript>Internationalization
Owner: js...@chromium.org
jshin, can you take a look?

Comment 19 by js...@chromium.org, May 24 2017

Mergedinto: -714301 722030
Status: Duplicate (was: Assigned)
Adam, this is the same as  bug 722030 . Hmm... 

Comment 20 by js...@chromium.org, May 24 2017

Mergedinto: -722030 720030
I meant  bug 720030 


Comment 21 by js...@chromium.org, May 24 2017

Blockedon: 720030
Status: Assigned (was: Duplicate)
Let's make this bug blocked by  bug 720030 

Project Member

Comment 22 by bugdroid1@chromium.org, May 27 2017

Labels: merge-merged-5.9
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1c171759ebb6e1a50ff0c5efcec9f6073b22e62a

commit 1c171759ebb6e1a50ff0c5efcec9f6073b22e62a
Author: Adam Klein <adamk@chromium.org>
Date: Sat May 27 21:40:43 2017

Revert "[intl] Fall back on an invalid default locale to "und""

This reverts commit 3059138b20bb56918cce24003832442c0ad701fa.

TBR=littledan@chromium.org

Bug:  v8:6288 ,  chromium:698855 ,  chromium:720030 
Change-Id: If4feb06c80f1f8f49c06ea6aeaffc8f1a072bdea
Reviewed-on: https://chromium-review.googlesource.com/517182
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/branch-heads/5.9@{#63}
Cr-Branched-From: fe9bb7e6e251159852770160cfb21dad3cf03523-refs/heads/5.9.211@{#1}
Cr-Branched-From: 70ad23791a21c0dd7ecef8d4d8dd30ff6fc291f6-refs/heads/master@{#44591}
[modify] https://crrev.com/1c171759ebb6e1a50ff0c5efcec9f6073b22e62a/src/js/i18n.js

Sorry for that bug, thanks for backporting the fix. I will try to stay more on top of these bugs; I was traveling around the time this was triaged.
Status: Fixed (was: Assigned)

Sign in to add a comment