New issue
Advanced search Search tips

Issue 698848 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression

Blocking:
issue 82385



Sign in to add a comment

BreakpadWinDeathTest.TestAccessViolation failing on CrWinAsan tester

Project Member Reported by thakis@chromium.org, Mar 6 2017

Issue description

BreakpadWinDeathTest.TestAccessViolation (run #1):
[ RUN      ] BreakpadWinDeathTest.TestAccessViolation
../../remoting/base/breakpad_win_unittest.cc(144): error: Actual function call count doesn't match EXPECT_CALL(*callbacks_, OnClientDumpRequested())...
         Expected: to be called once
           Actual: never called - unsatisfied and active
[  FAILED  ] BreakpadWinDeathTest.TestAccessViolation (341 ms)

e.g. here:
https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%20tester/builds/1625
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FCrWinAsan_tester%2F1634%2F%2B%2Frecipes%2Fsteps%2Fremoting_unittests%2F0%2Flogs%2FBreakpadWinDeathTest.TestAccessViolation%2F0


This started Feb 13. The code hasn't changed recently from what I can tell. scottmg updated breakpad, but later than Feb 13. So this is likely due to runtime changes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a9bed2a008dc2a98fa5f3af900a6bad79e5947f

commit 1a9bed2a008dc2a98fa5f3af900a6bad79e5947f
Author: rnk <rnk@chromium.org>
Date: Tue Mar 14 20:08:55 2017

Fix remoting_unittests!BreakpadWinDeathTest.TestAccessViolation under WinASan

The test should not expect to be called back for an access violation
when ASan is present. ASan will override the unhandled exception filter
and report such errors and terminate the process.

R=sergeyu@chromium.org
BUG= 698848 

Review-Url: https://codereview.chromium.org/2745373002
Cr-Commit-Position: refs/heads/master@{#456803}

[modify] https://crrev.com/1a9bed2a008dc2a98fa5f3af900a6bad79e5947f/remoting/base/breakpad_win_unittest.cc

Comment 2 by thakis@chromium.org, Apr 10 2017

Owner: r...@chromium.org
Status: Fixed (was: Untriaged)
Should be fixed now, right?

Comment 3 by r...@chromium.org, Apr 10 2017

Status: Verified (was: Fixed)
Yep, and we've had subsequent green builds.

Sign in to add a comment