Submitting via Gerrit to a branch does not work anymore |
|||||||||
Issue descriptionSee https://chromium-review.googlesource.com/c/449753/ and https://chromium-review.googlesource.com/c/449812/. This worked fine with Rietveld if a reviewer was a committer. Now it is only printing ============= invalid lineage footers Cr-Branched-From Please, unvote/vote on Commit Queue label to re-trigger on the same patchset. Bot data: {"action": "cancel", "triggered_at": "2017-03-06T09:11:50.0Z", "revision": "1998bea9f5d28092bdc8b7532762d1bb971b67bc"} =============
,
Mar 6 2017
This error is from go/git-numberer plugin that I wrote.
,
Mar 6 2017
Andy, can you please move this issue to Chromium tracker?
,
Mar 6 2017
,
Mar 6 2017
,
Mar 7 2017
,
Mar 7 2017
Another one: https://chromium-review.googlesource.com/c/451417
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/58ff145ef0aa4dd472e6eade4ad395a786c3a221 commit 58ff145ef0aa4dd472e6eade4ad395a786c3a221 Author: Michael Achenbach <machenbach@chromium.org> Date: Tue Mar 07 15:31:51 2017 [release] Temporarily disable gerrit for merge tools. BUG= chromium:698845 NOTRY=true TBR=hablich@chromium.org,tandrii@chromium.org Change-Id: I970c984c5e9bd23ca3d951d13243d107fc2a2e3f Reviewed-on: https://chromium-review.googlesource.com/451280 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43646} [modify] https://crrev.com/58ff145ef0aa4dd472e6eade4ad395a786c3a221/tools/release/common_includes.py [modify] https://crrev.com/58ff145ef0aa4dd472e6eade4ad395a786c3a221/tools/release/test_scripts.py
,
Mar 7 2017
I think I managed to reproduce the problem: https://chromium-review.googlesource.com/c/451281/ the Java-based Gerrit Generator spits out footers in wrong order. Let's see if I can make integration test repro.
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/git-numberer/+/da8b453c5efbe29fa767c02467ffa192f03c4630 commit da8b453c5efbe29fa767c02467ffa192f03c4630 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Mar 07 19:49:59 2017 Fix order of generated lineage when its size is at least 3. BUG= 698845 Change-Id: If0d4df9ec21b6a3748a2c6d2687e295a0f825156 Reviewed-on: https://chromium-review.googlesource.com/451281 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/da8b453c5efbe29fa767c02467ffa192f03c4630/src/main/java/com/googlesource/chromium/plugins/gitnumberer/Generator.java [modify] https://crrev.com/da8b453c5efbe29fa767c02467ffa192f03c4630/src/test/java/com/googlesource/chromium/plugins/gitnumberer/GeneratorTest.java [modify] https://crrev.com/da8b453c5efbe29fa767c02467ffa192f03c4630/src/main/java/com/googlesource/chromium/plugins/gitnumberer/PositionFooters.java
,
Mar 7 2017
The root cause fixed - my bug indeed :) Now goes the usual dance of importing this (internal http://cl/149446273) and waiting for Gerrit release. This will take ~1 week :(
,
Mar 8 2017
My CL is already in staging.
,
Mar 8 2017
,
Mar 14 2017
This is being deployed to prod today.
,
Mar 15 2017
This has been deployed fully.
,
Mar 15 2017
Ah, now we should revert the temporary disabling of Gerrit for branches in v8 here: https://chromium-review.googlesource.com/c/455799
,
Mar 15 2017
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/79e01fd9b03b8202c0662b75a7a95bac07b8745e commit 79e01fd9b03b8202c0662b75a7a95bac07b8745e Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Mar 15 20:24:31 2017 Revert "[release] Temporarily disable gerrit for merge tools." This reverts commit 58ff145ef0aa4dd472e6eade4ad395a786c3a221. Reason for revert: the bug in git-numberer has been fixed and deployed. Original change's description: > [release] Temporarily disable gerrit for merge tools. > > BUG= chromium:698845 > NOTRY=true > TBR=hablich@chromium.org,tandrii@chromium.org > > Change-Id: I970c984c5e9bd23ca3d951d13243d107fc2a2e3f > Reviewed-on: https://chromium-review.googlesource.com/451280 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Hablich <hablich@chromium.org> > Commit-Queue: Michael Hablich <hablich@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#43646} R=machenbach@chromium.org,hablich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG= chromium:698845 Change-Id: I34b12a36c21a2d7a46eb67bce0536298a0582dd5 Reviewed-on: https://chromium-review.googlesource.com/455799 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43840} [modify] https://crrev.com/79e01fd9b03b8202c0662b75a7a95bac07b8745e/tools/release/common_includes.py [modify] https://crrev.com/79e01fd9b03b8202c0662b75a7a95bac07b8745e/tools/release/test_scripts.py |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by hablich@chromium.org
, Mar 6 2017