Marking regression and RBB for M58. 

Is there a reason why this is RVG and not public?

I was not sure, so to be on the safer side filed it as RVG. Should i remove the RVG label?

Let's see if this is really related to preloading web sites.

kkhorimoto: Please evaluate to see if this should be RBB. Thanks!

 Issue 700417  has been merged into this issue.

Hi Kurt, since this was previously marked as RBB but then assigned to you for cause determination, can you please update what you think is happening here asap since we are about to go to TF with 58 soon?

https://codereview.chromium.org/2759563003/

 Issue 702108  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa0844ccdce295f9789664668f358d2df1a69b09

commit fa0844ccdce295f9789664668f358d2df1a69b09
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Mon Mar 20 17:01:26 2017

Display the preload Tab if it replaces the current Tab.

BUG= 698833 , 702431

Review-Url: https://codereview.chromium.org/2759563003
Cr-Commit-Position: refs/heads/master@{#458100}

[modify] https://crrev.com/fa0844ccdce295f9789664668f358d2df1a69b09/ios/chrome/browser/ui/browser_view_controller.mm

Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue is still reproducible on latest chrome canary version 59.0.3047.0.

I checked and it looks like the page is properly displayed in 59.0.3047.0 canary.  I'll merge after vbarigela verifies.

The issue is not fixed.

Precondition:
Chrome Menu --> Settings --> Bandwidth --> Preload webpages : On (only on Wifi) 

Steps followed to repro:
1.  Launch chrome.
2.  Open a tab and any URL EX: yahoo.com
3.  Close the tab.
4.  Type yahoo in omnibox.
5.  Wait for the page to preload.
6.  Tap on Go on keyboard.

Please check the videos:

iPhone 6 plus :  https://drive.google.com/a/google.com/file/d/0Bz2uwV55gGwDTEhTT0VQaERTdWs/view?usp=sharing

iPad Air : https://drive.google.com/a/google.com/file/d/0Bz2uwV55gGwDcTBzcUlyQjNxMWc/view?usp=sharing

Issue exist on the canary.ipa build picked up from iOS folder on pantheon: 

https://pantheon.corp.google.com/storage/browser/chrome-signed/ios-G1N/59.0.3047.0/iphoneos10.2/ios/1273/


Issue do not exist on the canary.ipa build picked up from iOS Canary folder on pantheon: 

https://pantheon.corp.google.com/storage/browser/chrome-signed/ios-G1N/59.0.3047.0/iphoneos10.2/ios-canary/567/

Thanks!

Pkl, can you please help with follow up and ownership to resolution while Kurt is ooto?

 Issue 703172  has been merged into this issue.

Vinutha, could you please bisect good and bad version for this bug and post git revisions from both. git revision can be found on about://version. Thanks!

Good Version - 58.0.3028.0 .
Good Version Revision - c49428ef69cfd173c5d7eaeb39982f44ca68da78-refs/heads/master@{#454140}
Link - https://drive.google.com/open?id=0B6GVWQnhaMClcnRHMGNpVDFVVkE

Bad Version - 58.0.3029.0
Link - https://drive.google.com/open?id=0B6GVWQnhaMClM2F2QnFCXzhaeWc

Thanks! I will bisect this further. 

I can not reproduce the problem with steps from comment #15 using Chrome 59.0.3049.0 which I downloaded from dogfoody website. I can easily reproduce the problem with Chrome Beta 58.0.3029.31. Can anyone else reproduce this bug with Canary?

Maybe 59.0.3047.0 did not have this fix yet? Vinutha, could you please try with 59.0.3049.0

Verified on iPad Pro iOS 10.2.1 on build 59.0.3049.0 Canary.Looks good.
https://drive.google.com/open?id=0B6GVWQnhaMCleUUybjdOS2ppV1U

Verified on iPhone 7 iOS 10.2.1 on build 59.0.3049.0 Canary.Looks good.

This bug requires manual review: Less than 29 days to go before AppStore submit on M58
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

BVC does not have tabModel:didReplaceTab:withTab:atIndex:, so this branch needs a different fix from trink

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

If it cannot be merged, should this bug be re-opened so a different fix can be created on M58 Branch?

I don't think we should reopen the bug. It still block release in the current state. Kurt, could you please land a separate fix on the branch.

Filed  issue 705637  as M58 RBS for tracking.
Relabeling this one to M59 and removing merge approval labels.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28c149b38283f61613fa2bea8da7e584df30a68c

commit 28c149b38283f61613fa2bea8da7e584df30a68c
Author: eugenebut <eugenebut@chromium.org>
Date: Tue Mar 28 17:55:32 2017

Cherry-picked Display the preload Tab if it replaces the current Tab.

BUG= 698833 , 702431,  705637 
Original Review-Url: https://codereview.chromium.org/2759563003
TBR=kkhorimoto@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2779763006
Cr-Commit-Position: refs/branch-heads/3029@{#454}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/28c149b38283f61613fa2bea8da7e584df30a68c/ios/chrome/browser/ui/browser_view_controller.mm

Verified on iPad Pro iOS 10.2.1 , iPhone 6+ iOS 10.2.1 on 58.0.3029.51 dev 
Pre-rendering is working.

 Issue 706838  has been merged into this issue.

verified the issue on iPad Mini iOS 10.2.1 tested on the build58.0.3029.52 beta.
Pre-rendering is working fine