New issue
Advanced search Search tips

Issue 698830 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

DevTools: search layout is broken

Project Member Reported by lushnikov@chromium.org, Mar 6 2017

Issue description

Chrome: 59.0.3033.0

Please refer to the screenshot, notice how "cancel" button is off.

This might require merge back to M-58.
 
search-is-badly-layouted.png
55.9 KB View Download

Comment 1 by l...@chromium.org, Mar 7 2017

Thanks for the report.

Bisected to this commit, which has not made it to M58 yet, so we do not need to merge:
https://chromium.googlesource.com/chromium/src/+/a90dba1f2dd094e51229dd2e5e059c6b53cee93a

To fix the layout, we can get rid of <table> and use flexbox to stretch, as shown in the images
findBar1.png
18.4 KB View Download
findBar2.png
23.3 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/336d5878c4c612627f0a8333f71b50a04b7091d1

commit 336d5878c4c612627f0a8333f71b50a04b7091d1
Author: luoe <luoe@chromium.org>
Date: Tue Mar 07 22:13:48 2017

DevTools: fix stretch layout in search/replace bar

SearchableView used to build the find and replace UI using <table>. A table
inside a flex container produced the strange behavior in the bug.

This CL fixes the visual bug, removes the table elements, and changes the layout
of the find/replace text inputs to stretch as much as possible.

BUG= 698830 

Review-Url: https://codereview.chromium.org/2734043002
Cr-Commit-Position: refs/heads/master@{#455244}

[modify] https://crrev.com/336d5878c4c612627f0a8333f71b50a04b7091d1/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js
[modify] https://crrev.com/336d5878c4c612627f0a8333f71b50a04b7091d1/third_party/WebKit/Source/devtools/front_end/ui/searchableView.css

Comment 3 by l...@chromium.org, Mar 9 2017

Status: Fixed (was: Assigned)
Labels: TE-Verified-59.0.3043.0 TE-Verified-M59
Verified the issue on Ubuntu 14.04 using chrome dev version #59.0.3043.0 as per comment #0.

Observed that "cancel" button is present and completely on without any cut.

Attaching screenshot for reference.

Hence, adding the verified labels.

Thanks...!!
find_in@698830.jpg
268 KB View Download

Sign in to add a comment