PopularSitesTest.AddsIconResourcesToDefaultPages fails in official builds |
|||||||
Issue descriptionStarted e.g. here: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/12534 https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%20tester/builds/5530 PopularSitesTest.AddsIconResourcesToDefaultPages (run #1): [ RUN ] PopularSitesTest.AddsIconResourcesToDefaultPages ../../components/ntp_tiles/popular_sites_impl_unittest.cc(247): error: Value of: popular_sites->sites().empty() Actual: true Expected: false [ FAILED ] PopularSitesTest.AddsIconResourcesToDefaultPages (1 ms) To repro, build with is_official_build=true, is_chrome_branded=true. Introduced by https://codereview.chromium.org/2695713004 Tests on the official bots are likely red because of that, so please take a look soon, or revert if investigating will take a while.
,
Mar 7 2017
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b98454a19f315047195fae5e6e4fd11a11e293d2 commit b98454a19f315047195fae5e6e4fd11a11e293d2 Author: fhorschig <fhorschig@chromium.org> Date: Tue Mar 07 10:06:12 2017 Check NTP resources only for mobile platforms Currently, only mobile platforms have resources that can be checked. This CL prevents attempts to test resources for non-mobile releases. (This is the way it has always been intended) BUG= 698824 Review-Url: https://codereview.chromium.org/2731403003 Cr-Commit-Position: refs/heads/master@{#455054} [modify] https://crrev.com/b98454a19f315047195fae5e6e4fd11a11e293d2/components/ntp_tiles/popular_sites_impl_unittest.cc
,
Mar 7 2017
,
Mar 8 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3f74617f5bec1f4cb23f3b14b9a4c5300c9e32d commit b3f74617f5bec1f4cb23f3b14b9a4c5300c9e32d Author: Marc Treib <treib@chromium.org> Date: Wed Mar 08 11:18:05 2017 Check NTP resources only for mobile platforms Currently, only mobile platforms have resources that can be checked. This CL prevents attempts to test resources for non-mobile releases. (This is the way it has always been intended) BUG= 698824 Review-Url: https://codereview.chromium.org/2731403003 Cr-Commit-Position: refs/heads/master@{#455054} (cherry picked from commit b98454a19f315047195fae5e6e4fd11a11e293d2) Review-Url: https://codereview.chromium.org/2735853005 . Cr-Commit-Position: refs/branch-heads/3029@{#60} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/b3f74617f5bec1f4cb23f3b14b9a4c5300c9e32d/components/ntp_tiles/popular_sites_impl_unittest.cc
,
Mar 8 2017
,
Aug 3 2017
Closing. Please reopen it if its not fixed. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by fhorschig@google.com
, Mar 7 2017