New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698823 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Console in dedicated DevTools for Node logs excessively

Project Member Reported by phulce@chromium.org, Mar 6 2017

Issue description

Chrome Version: 59.0.3032.0 (Official Build) canary (64-bit)
OS: OS X 
Node Version: 7.2.1

What steps will reproduce the problem?
(1) Navigate to 'chrome://inspect'
(2) Click on 'Open dedicated DevTools for Node'
(3) Open a shell with node in PATH
(4) Execute `node --inspect -e 'while (true) ;'` in shell
(5) Execute `console.log('foobar')` in DevTools console
(6) Kill the shell process
(7) Repeat 4-6 one or more times

What is the expected result? 'foobar' is logged to the console once per execution

What happens instead? 'foobar' is logged to the console N times per execution where N is the number of node processes ever inspected by this window

 
consolebug2.mp4
5.4 MB View Download
Cc: eostroukhov@chromium.org
Owner: dgozman@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91c48d5816474990959e57b67ad7f50b3472789f

commit 91c48d5816474990959e57b67ad7f50b3472789f
Author: dgozman <dgozman@chromium.org>
Date: Mon Mar 20 18:42:15 2017

[DevTools] Wait for cachedResourcesLoaded in ConsoleModel

We did this in ConsoleView which handled targets incorrectly.
ConsoleModel does it perfectly.

BUG= 698823 

Review-Url: https://codereview.chromium.org/2761573002
Cr-Commit-Position: refs/heads/master@{#458135}

[modify] https://crrev.com/91c48d5816474990959e57b67ad7f50b3472789f/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/91c48d5816474990959e57b67ad7f50b3472789f/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

Status: Fixed (was: Assigned)

Sign in to add a comment