New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698816 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

fix ukm name for parsestart metric

Project Member Reported by bmcquade@chromium.org, Mar 6 2017

Issue description

The change to add UKM support for additional metrics used the wrong name for the parsestart metric. We should fix and cherrypick into m58.
 
Status: Fixed (was: Started)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15bfa34181b01fc1bbf0cb20a55ba38e1edb6fb8

commit 15bfa34181b01fc1bbf0cb20a55ba38e1edb6fb8
Author: bmcquade <bmcquade@chromium.org>
Date: Mon Mar 06 21:38:14 2017

Fix name for UKM parse start metric.

BUG= 698816 

Review-Url: https://codereview.chromium.org/2736773002
Cr-Commit-Position: refs/heads/master@{#454966}

[modify] https://crrev.com/15bfa34181b01fc1bbf0cb20a55ba38e1edb6fb8/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc

Labels: Merge-Request-58
Status: Started (was: Fixed)
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 7 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 8 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f1b9e2a50800158d8eddcd7d299d2e366ac7991

commit 6f1b9e2a50800158d8eddcd7d299d2e366ac7991
Author: bmcquade <bmcquade@chromium.org>
Date: Wed Mar 08 04:09:42 2017

Fix name for UKM parse start metric.

BUG= 698816 
NOTRY=true
NOPRESUBMIT=true
TBR=rkaplow

Review-Url: https://codereview.chromium.org/2736773002
Cr-Commit-Position: refs/heads/master@{#454966}
(cherry picked from commit 15bfa34181b01fc1bbf0cb20a55ba38e1edb6fb8)

Review-Url: https://codereview.chromium.org/2737863003
Cr-Commit-Position: refs/branch-heads/3029@{#58}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/6f1b9e2a50800158d8eddcd7d299d2e366ac7991/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc

Status: Fixed (was: Started)

Sign in to add a comment