New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698796 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Task


Sign in to add a comment

[Media Router] Upstream the Media Router component extension

Project Member Reported by taku...@chromium.org, Mar 6 2017

Issue description

This bug is for tracking the work to upstream parts of the component extension that can be moved to Chromium.

(I'm filing this now to refer to from the readme for Media Router integration tests. Please feel free to edit the bug as necessary.)
 
Labels: -Type-Bug Type-Task
Cc: imch...@chromium.org
Owner: jrw@chromium.org
We will designate this as the master bug. We will open additional bugs for smaller sub-tasks. Assigning to jrw@ as overall owner.

Comment 3 by mfo...@chromium.org, Oct 26 2017

Components: -Blink>PresentationAPI Internals>Cast
Labels: M-64

Comment 4 by jrw@google.com, Dec 11 2017

Blocking: 774245

Comment 5 by jrw@google.com, Dec 11 2017

Labels: -M-64 M-65

Comment 6 by jrw@google.com, Dec 11 2017

Blockedon: 698796

Comment 7 by amp@chromium.org, Dec 11 2017

Blocking: -774245

Comment 8 by amp@chromium.org, Dec 11 2017

Blocking: -719718

Comment 9 by amp@chromium.org, Dec 11 2017

Blocking: -703329

Comment 10 by amp@chromium.org, Dec 11 2017

Blocking: -700572
Blockedon: -698796
Blocking: -699359 -698796 -699360 -699361 -699362 -699363
Fixing the blocking list.
Blocking: -698796
Blockedon: -698796
Blockedon: -699363
Two main remaining work items:

- Update --load-media-router-component-extension flag to configure which extension is loaded into Chromium/Chrome
- Update browser tests that rely on the component to set this flag appropriately

Cc: jrw@chromium.org
Components: -Internals>Cast Internals>Cast>Providers
Labels: -M-65 M-66
Owner: mfo...@chromium.org
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa57fe6dc96b40a58acc1ed6c268f47a881b590e

commit aa57fe6dc96b40a58acc1ed6c268f47a881b590e
Author: mark a. foltz <mfoltz@chromium.org>
Date: Wed Mar 14 04:28:30 2018

[Media Router] Converts integration tests to run on Chromium waterfall.

This updates the Media Router integration tests so they run in the
Chromium waterfall with the open source Media Router component
extension and its mock (test) Media Route Provider.

Additional changes:

- Removes extension from top level BUILD.gn as it is only used for
  browser tests at the moment.
- Splits the targets for Media Router browser tests into integration tests
  (part of main browser_tests suite), e2e tests (which require the
  external component extension), perf tests, and shared support code.
- Renames the "test" extension to the "telemetry" extension used for perf
  tests to avoid confusion.
- Updates README files
- One test is not compatible with the Chromium component and need
  to be fixed.  Bugs  818767  filed for follow-up.

Bug:  698796 
Change-Id: I6cc9302ffd72de95630ce33ca3617b3b73b9e722
Reviewed-on: https://chromium-review.googlesource.com/917214
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543005}
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/BUILD.gn
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/chrome/test/BUILD.gn
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/chrome/test/media_router/BUILD.gn
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/chrome/test/media_router/README.md
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/chrome/test/media_router/media_router_base_browsertest.cc
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/chrome/test/media_router/media_router_integration_browsertest.cc
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/chrome/test/media_router/media_router_integration_ui_browsertest.cc
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/chrome/test/media_router/media_router_one_ua_integration_browsertest.cc
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/chrome/test/media_router/telemetry/README.md
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/chrome/test/media_router/telemetry/extension/README.md
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/aa57fe6dc96b40a58acc1ed6c268f47a881b590e/testing/buildbot/gn_isolate_map.pyl

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8915f8376e97f5b62360a9e9efb8cdafa87ee23d

commit 8915f8376e97f5b62360a9e9efb8cdafa87ee23d
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed Mar 14 09:09:32 2018

Revert "[Media Router] Converts integration tests to run on Chromium waterfall."

This reverts commit aa57fe6dc96b40a58acc1ed6c268f47a881b590e.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 543005 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2FhNTdmZTZkYzk2YjQwYTU4YWNjMWVkNmMyNjhmNDdhODgxYjU5MGUM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/8508

Sample Failed Step: browser_tests

Original change's description:
> [Media Router] Converts integration tests to run on Chromium waterfall.
> 
> This updates the Media Router integration tests so they run in the
> Chromium waterfall with the open source Media Router component
> extension and its mock (test) Media Route Provider.
> 
> Additional changes:
> 
> - Removes extension from top level BUILD.gn as it is only used for
>   browser tests at the moment.
> - Splits the targets for Media Router browser tests into integration tests
>   (part of main browser_tests suite), e2e tests (which require the
>   external component extension), perf tests, and shared support code.
> - Renames the "test" extension to the "telemetry" extension used for perf
>   tests to avoid confusion.
> - Updates README files
> - One test is not compatible with the Chromium component and need
>   to be fixed.  Bugs  818767  filed for follow-up.
> 
> Bug:  698796 
> Change-Id: I6cc9302ffd72de95630ce33ca3617b3b73b9e722
> Reviewed-on: https://chromium-review.googlesource.com/917214
> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Derek Cheng <imcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543005}

Change-Id: Ifd1f688a7b89397491d849a6766f8d0510425e05
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  698796 
Reviewed-on: https://chromium-review.googlesource.com/962101
Cr-Commit-Position: refs/heads/master@{#543034}
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/BUILD.gn
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/chrome/test/BUILD.gn
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/chrome/test/media_router/BUILD.gn
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/chrome/test/media_router/README.md
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/chrome/test/media_router/media_router_base_browsertest.cc
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/chrome/test/media_router/media_router_integration_browsertest.cc
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/chrome/test/media_router/media_router_integration_ui_browsertest.cc
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/chrome/test/media_router/media_router_one_ua_integration_browsertest.cc
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/chrome/test/media_router/telemetry/README.md
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/chrome/test/media_router/telemetry/extension/README.md
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/8915f8376e97f5b62360a9e9efb8cdafa87ee23d/testing/buildbot/gn_isolate_map.pyl

Blockedon: 821717
Project Member

Comment 20 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cb5314ca50681891031d7ddd4d6e54b8bed04ae

commit 8cb5314ca50681891031d7ddd4d6e54b8bed04ae
Author: mark a. foltz <mfoltz@chromium.org>
Date: Wed Mar 14 23:58:19 2018

Reland "[Media Router] Converts integration tests to run on Chromium waterfall."

This is a reland of aa57fe6dc96b40a58acc1ed6c268f47a881b590e

Original change's description:
> [Media Router] Converts integration tests to run on Chromium waterfall.
>
> This updates the Media Router integration tests so they run in the
> Chromium waterfall with the open source Media Router component
> extension and its mock (test) Media Route Provider.
>
> Additional changes:
>
> - Removes extension from top level BUILD.gn as it is only used for
>   browser tests at the moment.
> - Splits the targets for Media Router browser tests into integration tests
>   (part of main browser_tests suite), e2e tests (which require the
>   external component extension), perf tests, and shared support code.
> - Renames the "test" extension to the "telemetry" extension used for perf
>   tests to avoid confusion.
> - Updates README files
> - One test is not compatible with the Chromium component and need
>   to be fixed.  Bugs  818767  filed for follow-up.
>
> Bug:  698796 
> Change-Id: I6cc9302ffd72de95630ce33ca3617b3b73b9e722
> Reviewed-on: https://chromium-review.googlesource.com/917214
> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Derek Cheng <imcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543005}

TBR=cliffordcheng, imcheng, jrw, sky

Bug:  698796 ,822029,  821717 
Change-Id: Ie5c2fdc9a838dec2906a73f7827fa6ceafdcce1b
Reviewed-on: https://chromium-review.googlesource.com/963064
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543242}
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/BUILD.gn
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/chrome/test/BUILD.gn
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/chrome/test/media_router/BUILD.gn
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/chrome/test/media_router/README.md
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/chrome/test/media_router/media_router_base_browsertest.cc
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/chrome/test/media_router/media_router_integration_browsertest.cc
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/chrome/test/media_router/media_router_integration_ui_browsertest.cc
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/chrome/test/media_router/media_router_one_ua_integration_browsertest.cc
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/chrome/test/media_router/telemetry/README.md
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/chrome/test/media_router/telemetry/extension/README.md
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/8cb5314ca50681891031d7ddd4d6e54b8bed04ae/testing/buildbot/gn_isolate_map.pyl

Status: Fixed (was: Assigned)
This was a rocky landing, but it has stuck.  Declaring this 7 (!) quarter project complete!

ヽ(´ー`)ノ

Followup work to de-flake our tests will be tracked in Bug 822231.

Sign in to add a comment