See PRD for details: https://docs.google.com/document/d/1n3AmgYsqod7Nz-7fddP0wnFZcjLT7cKymWFp-9dN9qA/edit?ts=58ad1d93#heading=h.99xgzomee8lb
c#2 was made thinking this was a different bug than it is. Adjusting priority back down.
Issue 661581 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69b6752a16b133e7dc53822317202bd6f81401dc commit 69b6752a16b133e7dc53822317202bd6f81401dc Author: spqchan <spqchan@chromium.org> Date: Wed Jun 07 20:56:56 2017 [Mac] Touch Bar Support for Dialogs Implemented touch bar for bookmark bubble, bookmark editor, and content setting bubble dialogs. Moved GetTouchBarId() and GetTouchBarItemId() from BrowserWindowTouchBar to foundation_util. Since the bookmark and bookmark editor dialogs contain textfields, their touch bar would be overridden by the textfields. To prevent that, the dialogs will provide a DialogTextFieldEditor object as a custom text field editor. Touch bar tests are added to: - bookmark_bubble_controller_unittest.mm - bookmark_editor_base_controller_unittest.mm - content_setting_bubble_cocoa_browsertest.mm Bug= 698795 Review-Url: https://codereview.chromium.org/2921083003 Cr-Commit-Position: refs/heads/master@{#477756} [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.h [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.mm [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/browser_window_touch_bar.h [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/browser_window_touch_bar.mm [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm [add] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/dialog_text_field_editor.h [add] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/chrome/browser/ui/cocoa/dialog_text_field_editor.mm [modify] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/ui/base/BUILD.gn [add] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/ui/base/cocoa/touch_bar_util.h [add] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/ui/base/cocoa/touch_bar_util.mm [add] https://crrev.com/69b6752a16b133e7dc53822317202bd6f81401dc/ui/base/cocoa/touch_bar_util_unittest.mm
Just need to ship
Comment 1 by spqc...@chromium.org
, Mar 6 2017