Consider using NSToolbar/NSTitlebarAccessoryViewController for the fullscreen toolbar |
||||
Issue descriptionUsing AppKit APIs to manage the toolbar in fullscreen would take a chunk of responsibility (animation, positioning based on menu bar visibility) away from Chrome. This would need special support for 10.9. Leave a comment if this has been tried before or there are known issues with doing it this way.
,
Mar 6 2017
Oh, huh. I'm interested in hacking on it when I have time (not right away), so let me know if you remember something about it? I searched and didn't find anything.
,
Mar 6 2017
Unfortunately, it's mostly undocumented and I dug around at it over a year ago. If I remember correctly, Chrome doesn't use a NSToolbar since it didn't work for some of the behavior we wanted, and we need to draw some things on it, like the avatar button and the tabstrip. It would be nice though, if you can hack into it and get Chrome to use a NSToolbar. Although you would want to check with MacViews and make sure this wouldn't get replaced by it.
,
Mar 6 2017
FYI, there are notes on using NSTitlebarAccessoryViewController in these links if you want to explore it https://groups.google.com/a/chromium.org/forum/#!topic/chromium-reviews/bIe4J-28TwQ https://chromium.googlesource.com/chromium/src.git/+/2657c891939f1e80c24db45dfd14fe3bc7fca66e%5E!/
,
Mar 6 2017
Thanks!
,
Mar 7 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 7 2018
This would still be desirable, even with MacViews.
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by spqc...@chromium.org
, Mar 6 2017