New issue
Advanced search Search tips

Issue 698782 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jul 26
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Presubmit false alarm with simple order change in DEPS file

Project Member Reported by wzhong@google.com, Mar 6 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
See https://codereview.chromium.org/2725293003/

Presubmit requires OWNERS stamp from dependent component (in this case ./net) when there is only a simple ordering change of DPES file in depending component.

https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/378342

<<<<<<
** Presubmit ERRORS **
You need LGTM from owners of depends-on paths in DEPS that were modified in this CL:
    '+net',

What is the expected behavior?
Presubmit shouldn't warn

What went wrong?
Presubmit falsely determines that a simple ordering change requires OWNERS stamp.

Did this work before? N/A 

Chrome version: 56.0.2924.87  Channel: stable
OS Version: 
Flash Version:

 
Labels: TE-NeedsTriageHelp
This issue seems to be out of TE-scope. Hence marking label as TE-NeedsTriageHelp for further investigation.

Thanks...!!
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 26 2017

Labels: Hotlist-Google
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 26

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment