Make shared EarlGrey matcher for context menu link to open new tab |
||
Issue description
This is the code that can be shared.
// Matcher for the Open in New Tab option in the context menu.
id<GREYMatcher> OpenInNewTabButton() {
return ButtonWithAccessibilityLabelId(IDS_IOS_CONTENT_CONTEXT_OPENLINKNEWTAB);
}
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc17746adff54984afff480136733114c6b3704b commit cc17746adff54984afff480136733114c6b3704b Author: baxley <baxley@chromium.org> Date: Wed Mar 08 19:52:49 2017 Rename matcher OpenLinkInNewTabMenuItem as OpenLinkInNewTabButton. All of our other matchers like this end in "Button", so this makes it consistent. If we want to distinguish menu items, it should be done everywhere. BUG= 698774 Review-Url: https://codereview.chromium.org/2739833003 Cr-Commit-Position: refs/heads/master@{#455520} [modify] https://crrev.com/cc17746adff54984afff480136733114c6b3704b/ios/chrome/browser/context_menu/context_menu_egtest.mm [modify] https://crrev.com/cc17746adff54984afff480136733114c6b3704b/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm [modify] https://crrev.com/cc17746adff54984afff480136733114c6b3704b/ios/chrome/browser/ui/history/history_ui_egtest.mm [modify] https://crrev.com/cc17746adff54984afff480136733114c6b3704b/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/cc17746adff54984afff480136733114c6b3704b/ios/chrome/test/earl_grey/chrome_matchers.mm
,
Mar 13 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 6 2017