"Create Job" button fails in Autotest AFE
Reported by
jrbarnette@chromium.org,
Mar 6 2017
|
|||||||
Issue description
If you go to the cautotest AFE, and click the "Create Job"
button, nothing happens.
I've observed the same thing in a test instance on my desktop.
Additionally, in that test instance, there's a Python exception
with the following message:
DatabaseError: (1146, "Table 'chromeos_autotest_db.afe_parameterizedjob' doesn't exist")
I'm not sure whether these symptoms are related.
,
Mar 6 2017
Reverting the change fixed the problem in my test instance.
,
Mar 6 2017
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f616e8fb22fcefa94ba18a6f2f8223fde642790f commit f616e8fb22fcefa94ba18a6f2f8223fde642790f Author: Richard Barnette <jrbarnette@chromium.org> Date: Mon Mar 06 18:33:37 2017 Revert "[autotest] Delete support for parameterized jobs." This reverts commit 0ed607598403c8e757b64b8c92f02f6b13a3eaee. BUG= chromium:698773 TEST=click "Create Job" in a local autotest instance Change-Id: I7d9f073d81f8a003cc79945e9608c78e9465dfb1 Reviewed-on: https://chromium-review.googlesource.com/449967 Commit-Queue: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Dan Shi <dshi@google.com> [modify] https://crrev.com/f616e8fb22fcefa94ba18a6f2f8223fde642790f/frontend/afe/model_attributes.py [modify] https://crrev.com/f616e8fb22fcefa94ba18a6f2f8223fde642790f/frontend/afe/rpc_utils.py [modify] https://crrev.com/f616e8fb22fcefa94ba18a6f2f8223fde642790f/frontend/afe/frontend_test_utils.py [modify] https://crrev.com/f616e8fb22fcefa94ba18a6f2f8223fde642790f/frontend/frontend_unittest.py [modify] https://crrev.com/f616e8fb22fcefa94ba18a6f2f8223fde642790f/global_config.ini [modify] https://crrev.com/f616e8fb22fcefa94ba18a6f2f8223fde642790f/frontend/afe/models_test.py [modify] https://crrev.com/f616e8fb22fcefa94ba18a6f2f8223fde642790f/frontend/afe/rpc_interface_unittest.py [modify] https://crrev.com/f616e8fb22fcefa94ba18a6f2f8223fde642790f/frontend/afe/models.py [modify] https://crrev.com/f616e8fb22fcefa94ba18a6f2f8223fde642790f/frontend/afe/rpc_interface.py
,
Mar 7 2017
,
Mar 7 2017
The cause is, when "parameterized_jobs" is not set, a null pointer exception is thrown at: https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/frontend/client/src/autotest/afe/create/CreateJobViewPresenter.java?rcl=0566ee79476fa9f39302e6e793a50f2cc8943316&l=1006 I have a quick fix for review as well.
,
Mar 7 2017
Re c#6: Sure enough. The patch below produces the
problem with the "Create Job" button:
diff --git a/frontend/afe/rpc_interface.py b/frontend/afe/rpc_interface.py
index c6e48820b..c81a63c83 100644
--- a/frontend/afe/rpc_interface.py
+++ b/frontend/afe/rpc_interface.py
@@ -1709,7 +1709,6 @@ def get_static_data():
result['motd'] = rpc_utils.get_motd()
result['drone_sets_enabled'] = models.DroneSet.drone_sets_enabled()
result['drone_sets'] = drone_sets
- result['parameterized_jobs'] = models.Job.parameterized_jobs_enabled()
result['status_dictionary'] = {"Aborted": "Aborted",
"Verifying": "Verifying Host",
That said, it doesn't explain bug 698936 . The patch above
doesn't cause that particular symptom, so I suspect that the
original CL had at least one other bug.
,
Mar 7 2017
,
Mar 8 2017
Revert is in, push to prod is done, and the symptom is gone for me.
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/45943a45a2bc84ffd621765e820967cf6d0888ae commit 45943a45a2bc84ffd621765e820967cf6d0888ae Author: Richard Barnette <jrbarnette@chromium.org> Date: Mon Apr 24 22:00:36 2017 Revert "[autotest] Delete support for parameterized jobs." This reverts commit 0ed607598403c8e757b64b8c92f02f6b13a3eaee. BUG= chromium:698773 TEST=click "Create Job" in a local autotest instance Change-Id: I7d9f073d81f8a003cc79945e9608c78e9465dfb1 Reviewed-on: https://chromium-review.googlesource.com/449967 Commit-Queue: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Dan Shi <dshi@google.com> (cherry picked from commit f616e8fb22fcefa94ba18a6f2f8223fde642790f) Reviewed-on: https://chromium-review.googlesource.com/481960 Reviewed-by: Michael Tang <ntang@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Commit-Queue: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/45943a45a2bc84ffd621765e820967cf6d0888ae/frontend/afe/model_attributes.py [modify] https://crrev.com/45943a45a2bc84ffd621765e820967cf6d0888ae/frontend/afe/rpc_utils.py [modify] https://crrev.com/45943a45a2bc84ffd621765e820967cf6d0888ae/frontend/afe/frontend_test_utils.py [modify] https://crrev.com/45943a45a2bc84ffd621765e820967cf6d0888ae/frontend/frontend_unittest.py [modify] https://crrev.com/45943a45a2bc84ffd621765e820967cf6d0888ae/global_config.ini [modify] https://crrev.com/45943a45a2bc84ffd621765e820967cf6d0888ae/frontend/afe/models_test.py [modify] https://crrev.com/45943a45a2bc84ffd621765e820967cf6d0888ae/frontend/afe/rpc_interface_unittest.py [modify] https://crrev.com/45943a45a2bc84ffd621765e820967cf6d0888ae/frontend/afe/models.py [modify] https://crrev.com/45943a45a2bc84ffd621765e820967cf6d0888ae/frontend/afe/rpc_interface.py
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jrbarnette@chromium.org
, Mar 6 2017This CL is an obvious suspect: https://chromium-review.googlesource.com/#/c/436407/ I'm going to test reverting, and see what it gets me.