Kitchen should export a LogDog Stream Server and Coordinator Host. |
||||
Issue descriptionCurrently, Kitchen runs with baked-in Annotee and Butler packages. It doesn't create or export a LogDog stream server, though, nor does it export a LOGDOG_COORDINATOR_HOST environment variable. It needs a stream server so that delegate processes (and, ultimately, recipe engine) can create streams through it. It needs to export the host so that subprocesses can generate log links to the streams that they create.
,
Mar 6 2017
,
Mar 6 2017
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/66a9c7cb1e03d984da7d0f5e12eebe2065b95602 commit 66a9c7cb1e03d984da7d0f5e12eebe2065b95602 Author: dnj <dnj@chromium.org> Date: Tue Mar 07 01:31:54 2017 Butler stream servers can generate client address. Allow a StreamServer instance to generate client addresses. These addresses can be processed by the stream client package to generate a client for the corresponding StreamServer. This also adds tests for UNIX and Windows stream server implementations. These tests have the bonus of actually tying together this Address() string to the "streamclient" package, confirming that they are functional together. In order for this connection to be made, the circular dependency that "streamclient" had on "/logdog/client/butler" had to be broken. This is done by moving the "local" client implementation into the "butler" package space. This makes sense, since this implementation is an internalization of the stream server. BUG= chromium:698768 TEST=None Review-Url: https://codereview.chromium.org/2737603003 [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butler/butler_test.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butler/streamserver/base.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butler/streamserver/base_test.go [rename] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butler/streamserver/localclient/local.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butler/streamserver/namedPipe_posix.go [add] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butler/streamserver/namedPipe_posix_test.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butler/streamserver/namedPipe_windows.go [add] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butler/streamserver/namedPipe_windows_test.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butler/streamserver/streamserver.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butlerlib/streamclient/client.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butlerlib/streamclient/client_namedPipe_windows.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butlerlib/streamclient/client_test.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butlerlib/streamclient/stream.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/butlerlib/streamclient/stream_test.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/cmd/logdog_butler/main_posix.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/cmd/logdog_butler/main_windows.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/cmd/logdog_butler/subcommand_run.go [modify] https://crrev.com/66a9c7cb1e03d984da7d0f5e12eebe2065b95602/logdog/client/cmd/logdog_butler/subcommand_serve.go
,
Mar 8 2017
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/0915deebb8f34d081f3f98b38b1fb0eb237a86b5 commit 0915deebb8f34d081f3f98b38b1fb0eb237a86b5 Author: Dan Jacques <dnj@chromium.org> Date: Wed Mar 08 01:39:51 2017 Kitchen: Add LogDog host and stream server. Add a LogDog streamserver to Kitchen that can be accessed by subprocesses. This will allow them to export their own log streams through the Kitchen LogDog instances. Also export the Coordinator host. Also roll luci-go: infra/go/src/github.com/luci/luci-go: 724d1d55 Set default value for -service-account-json flag. 00615782 LogDog: Use "winio" instead of "npipe". e4105d6b Disable Windows npipe test b/c of flake. ef3b1635 Fix overly sensitive tests after gRPC roll. de5cf3bf Add TCP4/6 stream server support to LogDog Butler 66a9c7cb Butler stream servers can generate client address. 670c47cc Milo: In LogDog-only mode, only render LogDog link a73824c4 Milo: Add "log_location" support to BuildBot. 5bbff2a9 Remove PubSub based flush for GAE tsmon. 550b8f1f Make common/isolatedclient importable on GAE. 044e6adb Milo: Render summary-level links. d4e9308a Add authentication help, fix CLI name. d82ae617 Milo: Remove swarming tags from build properties 22029efb Milo: Strip out memcache for logdog builds 7f5da596 scheduler: Add tsmon house keeping cron. BUG= chromium:698768 TEST=None Change-Id: Idd7c9aeb5bc541c4ef0eefd0c12de7ab2e5f9dce Reviewed-on: https://chromium-review.googlesource.com/450820 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [add] https://crrev.com/0915deebb8f34d081f3f98b38b1fb0eb237a86b5/go/src/infra/tools/kitchen/cook_logdog_windows.go [add] https://crrev.com/0915deebb8f34d081f3f98b38b1fb0eb237a86b5/go/src/infra/tools/kitchen/cook_logdog_posix.go [modify] https://crrev.com/0915deebb8f34d081f3f98b38b1fb0eb237a86b5/go/src/infra/tools/kitchen/cook_logdog.go [modify] https://crrev.com/0915deebb8f34d081f3f98b38b1fb0eb237a86b5/DEPS |
||||
►
Sign in to add a comment |
||||
Comment 1 by d...@chromium.org
, Mar 6 2017