New issue
Advanced search Search tips

Issue 698766 link

Starred by 4 users
Status: Fixed
Owner:
wjmaclean@chromium.org
Closed: Nov 5
Cc:
wjmaclean@chromium.org
mcnee@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 654917


Sign in to add a comment

Remove GuestViewBase::OwnerContentsObserver::OnPageScaleFactorChanged

Project Member Reported by mcnee@chromium.org, Mar 6 2017 
Using GuestViewBase::OwnerContentsObserver::OnPageScaleFactorChanged to propagate the page scale factor causes the scale transformation to be applied twice in the GuestView. We currently do this so that the GuestView is better rastered. Once 654917 is fixed, we will have the correct raster scale in subframes which will make the propagation of the page scale factor unnecessary for the purpose of rasterization.

Comment 1 by mcnee@chromium.org, Mar 6 2017

Cc: mcnee@chromium.org
 Issue 670005  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a90bffaa3407289c413cb385e631e70547c586e

commit 2a90bffaa3407289c413cb385e631e70547c586e
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Mon Nov 05 20:52:47 2018

Plumb page scale factor to oopifs via SynchronizeVisualProperties.

This CL implements the plumbing of page-scale factor to OOPIFs by
including it in the VisualProperties sync pathway. The main frame's
page scale factor is represented in cc/ by |external_page_scale_factor|
and only affects the calculation of raster scale.

The vast majority of this CL is plumbing, with the main logic
change occuring in picture_layer_impl.cc.

Bug:  654917 ,  698766 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia3f65e45be32c5a6033f3afaccb965dde597eee9
Reviewed-on: https://chromium-review.googlesource.com/c/1286437
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605456}
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/cc/trees/layer_tree_host.h
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/cc/trees/render_frame_metadata.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/cc/trees/render_frame_metadata.h
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/components/guest_view/browser/guest_view_base.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/browser/renderer_host/frame_connector_delegate.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/browser/renderer_host/input/fling_scheduler.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/common/frame_messages.h
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/common/frame_visual_properties.h
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/common/render_frame_metadata.mojom
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/common/render_frame_metadata_struct_traits.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/common/render_frame_metadata_struct_traits.h
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/common/visual_properties.h
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/common/widget_messages.h
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/public/test/browser_test_utils.h
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/renderer/gpu/layer_tree_view.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/renderer/gpu/layer_tree_view.h
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/renderer/render_frame_metadata_observer_impl.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/renderer/render_view_impl.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/renderer/render_widget.cc
[modify] https://crrev.com/2a90bffaa3407289c413cb385e631e70547c586e/content/renderer/render_widget.h

Comment 3 by wjmaclean@chromium.org, Nov 5

Owner: wjmaclean@chromium.org
Status: Fixed (was: Assigned)
Optimistically marking this as closed.
►

Sign in to add a comment