New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 698763 link

Starred by 1 user
Status: Fixed
Owner:
drott@chromium.org
Closed: Mar 2017
Cc:
█ raphael....@intel.com
drott@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

freetype-android and freetype2 unification breaks is_component_build=True with missing FT_GlyphSlot_Embolden

Project Member Reported by raphael....@intel.com, Mar 6 2017 
I'm on Fedora 25 with cairo 1.14.8 and freetype 2.6.5. Fedora's freetype seems to be built with different options compared to Chromium's freetype-android.

This causes runtime failures when building with is_component_build=True:
    ./out/Debug/content_shell: symbol lookup error: /lib64/libcairo.so.2: undefined symbol: FT_GlyphSlot_Embolden

If it's not possible to always build it as a static library again, something like ffmpeg's |is_component_ffmpeg| would really come in handy.

Comment 1 by drott@chromium.org, Mar 6 2017

Cc: raphael....@intel.com
Owner: drott@chromium.org
Status: Assigned (was: Untriaged)
Sorry for the breakage. Could you try if it is fixed by adding ftsynth.c to the list of sources files in BUILD.gn? In that case we could add it to the sources if is_linux.

Comment 2 by raphael....@intel.com, Mar 6 2017 

Confirmed, content_shell ran fine after I added it to BUILD.gn :-)

Comment 3 by drott@chromium.org, Mar 7 2017 

Okay, thanks for checking, I'll prepare a CL.

Comment 4 by drott@chromium.org, Mar 8 2017 

Fix up https://codereview.chromium.org/2739853002/ - Could you check if this one works for you? Obrigado.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c656e7549443124d7c13dce0b808a1f19cd0df4

commit 2c656e7549443124d7c13dce0b808a1f19cd0df4
Author: drott <drott@chromium.org>
Date: Wed Mar 08 15:27:18 2017

Fix FreeType component build on Fedora

BUG= 698763 

Review-Url: https://codereview.chromium.org/2739853002
Cr-Commit-Position: refs/heads/master@{#455455}

[modify] https://crrev.com/2c656e7549443124d7c13dce0b808a1f19cd0df4/third_party/freetype/BUILD.gn

Comment 6 by drott@chromium.org, Mar 8 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment