New issue
Advanced search Search tips

Issue 698754 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 688611
issue 709020



Sign in to add a comment

Dynamically attach VrShellDelegate to whichever activity has input focus.

Project Member Reported by mthiesse@chromium.org, Mar 6 2017

Issue description

VrShellDelegate currently attaches to the first activity that creates it, and stays attached indefinitely. It should attach to whichever activity has input focus (for now just ChromeTabbedActivity/2).
 
Blocking: 688611
Blocking: 709020
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7198dc47acec10e7f5ee3be1eebb8f3d26560e8e

commit 7198dc47acec10e7f5ee3be1eebb8f3d26560e8e
Author: mthiesse <mthiesse@chromium.org>
Date: Tue Apr 11 00:56:54 2017

Dynamically attach VrShellDelegate to the most recently resumed supported Activity.

This CL moves some of the refactoring out https://codereview.chromium.org/2776243007/ to simplify that already complicated CL.

BUG= 698754 

Review-Url: https://codereview.chromium.org/2801883002
Cr-Commit-Position: refs/heads/master@{#463478}

[modify] https://crrev.com/7198dc47acec10e7f5ee3be1eebb8f3d26560e8e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Status: Fixed (was: Available)

Sign in to add a comment