New issue
Advanced search Search tips

Issue 698748 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: 2
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Implement CommandDispatcher

Project Member Reported by rohitrao@chromium.org, Mar 6 2017

Issue description

Used to route command messages to the appropriate coordinators, without having to plumb "handler" pointers down through the coordinator hierarchy.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dc19b0874e342a145a3a648a2c82a05406065c0

commit 5dc19b0874e342a145a3a648a2c82a05406065c0
Author: rohitrao <rohitrao@chromium.org>
Date: Fri Mar 10 16:34:17 2017

[ios] Adds a CommandDispatcher to proxy method calls to UI handlers.

This class will be used by the command architecture in the clean skeleton app.
View controllers will receive a pointer to a CommandDispatcher and can use it to
send command methods to the appropriate coordinators.

BUG= 698748 
TEST=None

Review-Url: https://codereview.chromium.org/2734863002
Cr-Commit-Position: refs/heads/master@{#456075}

[modify] https://crrev.com/5dc19b0874e342a145a3a648a2c82a05406065c0/ios/clean/chrome/browser/ui/commands/BUILD.gn
[add] https://crrev.com/5dc19b0874e342a145a3a648a2c82a05406065c0/ios/clean/chrome/browser/ui/commands/command_dispatcher.h
[add] https://crrev.com/5dc19b0874e342a145a3a648a2c82a05406065c0/ios/clean/chrome/browser/ui/commands/command_dispatcher.mm
[add] https://crrev.com/5dc19b0874e342a145a3a648a2c82a05406065c0/ios/clean/chrome/browser/ui/commands/command_dispatcher_unittest.mm
[modify] https://crrev.com/5dc19b0874e342a145a3a648a2c82a05406065c0/ios/clean/chrome/test/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0203b9af9ab794f10f9d59c4aaa01f5873695ed0

commit 0203b9af9ab794f10f9d59c4aaa01f5873695ed0
Author: rohitrao <rohitrao@chromium.org>
Date: Fri Mar 24 15:49:34 2017

[ios] Moves CommandDispatcher to ios/shared and adds it to Browser.

BUG= 698748 

Review-Url: https://codereview.chromium.org/2745223005
Cr-Commit-Position: refs/heads/master@{#459434}

[modify] https://crrev.com/0203b9af9ab794f10f9d59c4aaa01f5873695ed0/ios/chrome/test/BUILD.gn
[modify] https://crrev.com/0203b9af9ab794f10f9d59c4aaa01f5873695ed0/ios/clean/chrome/browser/ui/commands/BUILD.gn
[modify] https://crrev.com/0203b9af9ab794f10f9d59c4aaa01f5873695ed0/ios/clean/chrome/test/BUILD.gn
[modify] https://crrev.com/0203b9af9ab794f10f9d59c4aaa01f5873695ed0/ios/shared/chrome/browser/ui/browser_list/BUILD.gn
[modify] https://crrev.com/0203b9af9ab794f10f9d59c4aaa01f5873695ed0/ios/shared/chrome/browser/ui/browser_list/browser.h
[modify] https://crrev.com/0203b9af9ab794f10f9d59c4aaa01f5873695ed0/ios/shared/chrome/browser/ui/browser_list/browser.mm
[add] https://crrev.com/0203b9af9ab794f10f9d59c4aaa01f5873695ed0/ios/shared/chrome/browser/ui/commands/BUILD.gn
[rename] https://crrev.com/0203b9af9ab794f10f9d59c4aaa01f5873695ed0/ios/shared/chrome/browser/ui/commands/command_dispatcher.h
[rename] https://crrev.com/0203b9af9ab794f10f9d59c4aaa01f5873695ed0/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm
[rename] https://crrev.com/0203b9af9ab794f10f9d59c4aaa01f5873695ed0/ios/shared/chrome/browser/ui/commands/command_dispatcher_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment