New issue
Advanced search Search tips

Issue 698737 link

Starred by 1 user
Status: Fixed
Owner:
steimel@chromium.org
Closed: Oct 2017
Cc:
beccahughes@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Native video control does not match video length when video is rotated using CSS

Reported by gibbok.c...@gmail.com, Mar 6 2017 
UserAgent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
1. Use Chrome 56.0.2924.87
2. Visit test case https://jsbin.com/sigijukeco/edit?html,output
3. Click button "Click me to rotate video" for more then 4 times, the video start to rotate.

What is the expected behavior?
- The native video control should match the video length when rotated.

What went wrong?
- The native video control does not match the video length when rotated.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 56.0.2924.87  Channel: stable
OS Version: 6.3
Flash Version: 

Same issue on Chrome Version 59.0.3032.0 canary (64-bit)

Comment 1 by krajshree@chromium.org, Mar 7 2017

Components: Blink>Media>Controls
Labels: -Type-Bug -Pri-2 hasbisect-per-revision M-56 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: mlamouri@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, Mac 10.12.3 and Ubuntu 14.04 using chrome reported version #56.0.2924.87 and latest canary #59.0.3032.0.

Bisect Information:
=====================
Good build: 56.0.2907.0  Revision(429169)

Bad Build : 56.0.2908.0  Revision(429486)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/be10da649c394e30378885e6b73d75257aa2aff5..3347bb8ad251e778ed35c433c0246e0659f2402d

From the above change log suspecting below change

Review url: https://codereview.chromium.org/2470503003

mlamouri@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks...!!

Comment 2 by lethalantidote@chromium.org, Sep 19 2017 

Should we archive this considering the new media controls will be rolling out?

Comment 3 by mlamouri@chromium.org, Sep 19 2017

Cc: beccahughes@chromium.org mlamouri@chromium.org
Owner: steimel@chromium.org
steimel@, could you have a look at this when you have some free cycles? I think ::ComputePanelWidth() cuts the media controls because it believes they are not visible. That's my best guess.

Comment 4 by steimel@chromium.org, Sep 19 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2664ce7f1a07c96591f1039ba0d475857eef484

commit b2664ce7f1a07c96591f1039ba0d475857eef484
Author: Tommy Steimel <steimel@chromium.org>
Date: Tue Sep 26 02:05:54 2017

Update ComputePanelWidth calculation to properly handle rotations

Bug:  698737 
Change-Id: I954b7c6e2aa1b56a742a4a2787093fa413b5f47c
Reviewed-on: https://chromium-review.googlesource.com/676202
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504262}
[add] https://crrev.com/b2664ce7f1a07c96591f1039ba0d475857eef484/third_party/WebKit/LayoutTests/media/controls/rotated-video-has-right-panel-width.html
[modify] https://crrev.com/b2664ce7f1a07c96591f1039ba0d475857eef484/third_party/WebKit/Source/core/layout/LayoutMedia.cpp

Comment 6 by steimel@chromium.org, Oct 2 2017

Status: Fixed (was: Started)
►

Sign in to add a comment