New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698734 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Reading list dialog allows two actions at a time.

Project Member Reported by vbarig...@chromium.org, Mar 6 2017

Issue description

App Version: 57.0.2987.94 dev
iOS Version: 10.2.1
Device: iPhone, iPad
URL: 

Steps to reproduce:
  1.  Launch chrome
  2.  Open any URL 
  3.  Chrome Menu --> Share --> Chrome Read later
  4.  Chrome Menu --> Reading List --> Edit --> Mark all read
  5.  Edit --> Place one finger on “Delete Read” --> Tap on “Mark All”
  6.  Release finger on “Delete Read” 

Observed results:
Notice that reading list entry is deleted with pop up “Mark All Read” and “Mark All Unread” on top.

Expected results:
At Step 5:  Two actions should not be allowed at a time.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): New feature on M57
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes

Link to video/image:  https://drive.google.com/a/google.com/file/d/0Bz2uwV55gGwDMDN4YW1zT21Obk0/view?usp=sharing
 

Comment 1 by pkl@chromium.org, Mar 6 2017

Cc: gambard@chromium.org jif@chromium.org
Labels: -Restrict-View-Google M-58
Owner: olivierrobin@chromium.org
Status: Assigned (was: Untriaged)
Owner: gambard@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5335812ed82d27b1bb71b600aea290a45085ea32

commit 5335812ed82d27b1bb71b600aea290a45085ea32
Author: gambard <gambard@chromium.org>
Date: Tue Mar 07 09:37:28 2017

Dismiss MarkAllAs when leaving ReadingList edit

BUG= 698734 

Review-Url: https://codereview.chromium.org/2736003002
Cr-Commit-Position: refs/heads/master@{#455051}

[modify] https://crrev.com/5335812ed82d27b1bb71b600aea290a45085ea32/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm

Labels: Merge-Request-58
Status: Fixed (was: Assigned)
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 7 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 7 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7313ec06be7cfcdfc59fcec477a07d1b04a1e011

commit 7313ec06be7cfcdfc59fcec477a07d1b04a1e011
Author: gambard <gambard@chromium.org>
Date: Tue Mar 07 09:49:44 2017

Dismiss MarkAllAs when leaving ReadingList edit

BUG= 698734 

Review-Url: https://codereview.chromium.org/2736003002
Cr-Commit-Position: refs/heads/master@{#455051}
(cherry picked from commit 5335812ed82d27b1bb71b600aea290a45085ea32)

Review-Url: https://codereview.chromium.org/2739613002 .
Cr-Commit-Position: refs/branch-heads/3029@{#40}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/7313ec06be7cfcdfc59fcec477a07d1b04a1e011/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm

Status: Verified (was: Fixed)
https://drive.google.com/open?id=0B6GVWQnhaMCleVdVS2ZJZ3pFQ3c
Verified on 59.0.3041.0 Canary in iPhone 7+ iOS 10.2.1, iPad Pro iOS 10.2.1
MarkAllAs is dismissed leaving ReadingList edit.
Delete Read action happens.
Verified on 58.0.3029.19 beta, on iPhone6+ 10.2.1,iPadAir 10.2.1 Delete Read actions is working fine. MarkAll as is dismissed leaving Reading list edit.

Sign in to add a comment