When device is compact, display share icon in the toolbar |
|||||
Issue descriptionDevice: iPhone 6+/6s+/7+ only. What steps will reproduce the problem? (1) Set the iPhone in landscape What is the expected result? The device is compact. The Share icon should be directly accessible from the toolbar. What happens instead? The share menu is accessible from the toolbar menu. By fixing this bug, the Reading List empty state background should also be updated.
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70079b5955de2a047669c39938839851fb107b44 commit 70079b5955de2a047669c39938839851fb107b44 Author: gambard <gambard@chromium.org> Date: Mon Mar 06 13:37:16 2017 Display menu icon in iPhone X+ in landscape BUG= 697837 , 698726 Review-Url: https://codereview.chromium.org/2732993002 Cr-Commit-Position: refs/heads/master@{#454861} [modify] https://crrev.com/70079b5955de2a047669c39938839851fb107b44/ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71e8c8e8d90be82630097c95d17e18d41c91be3a commit 71e8c8e8d90be82630097c95d17e18d41c91be3a Author: gambard <gambard@chromium.org> Date: Tue Mar 07 09:11:15 2017 Display menu icon in iPhone X+ in landscape BUG= 697837 , 698726 Review-Url: https://codereview.chromium.org/2732993002 Cr-Commit-Position: refs/heads/master@{#454861} (cherry picked from commit 70079b5955de2a047669c39938839851fb107b44) Review-Url: https://codereview.chromium.org/2736893002 . Cr-Commit-Position: refs/branch-heads/3029@{#39} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/71e8c8e8d90be82630097c95d17e18d41c91be3a/ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm
,
Mar 10 2017
,
Jun 22 2018
jif@ is no longer on the team. Releasing his bugs for triage.
,
Jun 27 2018
This issues has been solved by UIRefresh, where we show that share icon on the status bar. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by gambard@chromium.org
, Mar 6 2017Status: Assigned (was: Untriaged)