New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 698694 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: Apr 2018
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

‘Edit’ button is seen instead of ‘Save’ button for edit option of chrome://md-settings/content/cookies

Reported by dmascare...@etouch.net, Mar 6 2017 
Chrome Version::59.0.3032.0 f82c6edf451db714b211a7c92b9c1ca3547ab0ec-refs/heads/master@{#454806}
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

What steps will reproduce the problem?
1. Launch Chrome and navigate to chrome://md-settings/content/cookies
2. Add exception in 'Block/Allow/Clear on exit' and click on 'Action menu' against it
3. Select 'Edit' option from Action menu and observe overlay button.

Actual:‘Edit’ button is seen instead of ‘Save’ button for edit option.
Expected: Save button should be seen.(Similarly to Manage search engine)

This is a non-regression issue, seen from M-58 series as this is new feature introduced in build # 58.0.3022.0
Actual.mov
1.5 MB Download

Comment 1 by ranjitkan@chromium.org, Mar 6 2017

Status: Untriaged (was: Unconfirmed)
Untriaged so that it gets addressed.

Comment 2 by dpa...@chromium.org, Apr 3 2018

Cc: aee@chromium.org
Labels: OS-Chrome
Status: Available (was: Untriaged)
I agree that we should change the button from "Edit" to "Save". This also matches what  we do for Search engines and startup URLs (see screenshots).
startup_url_save.png
8.0 KB View Download
search_engines_save.png
18.6 KB View Download
cookies_edit.png
6.8 KB View Download

Comment 3 by aee@chromium.org, Apr 3 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51a909250b38bcad76ff70b55feccbe899b9e0ca

commit 51a909250b38bcad76ff70b55feccbe899b9e0ca
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Apr 04 01:45:08 2018

Settings WebUI: change button text to Save

Bug:  698694 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I55642580b173c544659cceee504ecef035047d9b
Reviewed-on: https://chromium-review.googlesource.com/992869
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547931}
[modify] https://crrev.com/51a909250b38bcad76ff70b55feccbe899b9e0ca/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html

Comment 5 by aee@chromium.org, Apr 4 2018

Status: Fixed (was: Started)

Comment 6 by shruti.j...@etouch.net, Apr 5 2018

Labels: TE-Verified-67.0.3389.0 TE-Verified-M67
Update : 
Retested above issue on Windows(7,8,8.1,10), Linux(14.04 LTS )and Mac(10.12.6, 10.13.1, 10.13.4) OS using latest Canary #67.0.3389.0 and issue is fixed.  Kindly review the attached screen-cast.

Thank you!
Canarybehaviour_67.0.3389.0.mov
23.3 MB Download
►

Sign in to add a comment